Skip to content

Tidal turbine power curve generation #1181

Merged
mjprilliman merged 24 commits into
patchfrom
tidal-turbine-cf
Jul 31, 2024
Merged

Tidal turbine power curve generation #1181
mjprilliman merged 24 commits into
patchfrom
tidal-turbine-cf

Conversation

@mjprilliman

Copy link
Copy Markdown
Collaborator

-See NatLabRockies/SAM#1807 for details on SAM side
-Update ssc equation for capacity factor to calculate rated turbine power, power curve across tidal velocities

qualand and others added 22 commits January 16, 2024 10:43
for characterizing the cycle performance for external control
Merge some of Dao-TK features into develop
)

* Add check for crit load unmet to self consumption metrics

* Correct size versus iprofile index for manual dispatch fuel cell and grid discharge arrays

* update git attributes file to correctly calculate language breakdown of project with linguist (#1119)

* Fix trough dispatch (#1121)

* define outputs required downstream

* move new outputs to design point section of cmod

* add sim_type required if to financial model inputs

* Add check to ensure trough_loop_control and nSCA agree

* Add check to IPH to ensure trough_loop_control and nSCA agree

* Remove nSCA as an input for CSP and IPH models. Add as design output.

---------

Co-authored-by: Taylor Brown <60201147+taylorbrown75@users.noreply.github.com>

* Remove overwriting of global variables in back surface irradiance calcs
for loss diagram metrics

* Use decomposed DNI when weather file DNI not available for allen
clipping correction

* Check irradiance mode before using dni decomp in allen method (i.e. is
code failing due to no dni provided)

* Address SAM issue 1676

* Fix GitHub Actions failing tests

* Fix failing macOS Github actions due to original root branch getem-cost-updates

* Test all previously failing tests on all platforms

* Reinstate all ssc tests for pull request approval

* Update REQUIRED_IF for ssc_auto_exec variables for SAM issue 1634

---------

Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov>
Co-authored-by: Janine Keith <janinefreeman@users.noreply.github.com>
Co-authored-by: tyneises <ty.neises@nrel.gov>
Co-authored-by: Taylor Brown <60201147+taylorbrown75@users.noreply.github.com>
Co-authored-by: Matt Prilliman <Matthew.Prilliman@nrel.gov>
Co-authored-by: Matt Prilliman <54449384+mjprilliman@users.noreply.github.com>
remove lat from cmod and replace with weather reader parameter in exec
@mjprilliman mjprilliman added the mhk marine hydrokinetic label Jul 16, 2024
@mjprilliman mjprilliman added this to the SAM Fall 2024 Release milestone Jul 16, 2024
@mjprilliman mjprilliman requested a review from cpaulgilman July 16, 2024 15:52
@mjprilliman mjprilliman self-assigned this Jul 16, 2024
@mjprilliman mjprilliman deleted the tidal-turbine-cf branch July 31, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants