Fix trough dispatch#1121
Merged
Merged
Conversation
tyneises
pushed a commit
that referenced
this pull request
Mar 15, 2024
) * Add check for crit load unmet to self consumption metrics * Correct size versus iprofile index for manual dispatch fuel cell and grid discharge arrays * update git attributes file to correctly calculate language breakdown of project with linguist (#1119) * Fix trough dispatch (#1121) * define outputs required downstream * move new outputs to design point section of cmod * add sim_type required if to financial model inputs * Add check to ensure trough_loop_control and nSCA agree * Add check to IPH to ensure trough_loop_control and nSCA agree * Remove nSCA as an input for CSP and IPH models. Add as design output. --------- Co-authored-by: Taylor Brown <60201147+taylorbrown75@users.noreply.github.com> * Remove overwriting of global variables in back surface irradiance calcs for loss diagram metrics * Use decomposed DNI when weather file DNI not available for allen clipping correction * Check irradiance mode before using dni decomp in allen method (i.e. is code failing due to no dni provided) * Address SAM issue 1676 * Fix GitHub Actions failing tests * Fix failing macOS Github actions due to original root branch getem-cost-updates * Test all previously failing tests on all platforms * Reinstate all ssc tests for pull request approval * Update REQUIRED_IF for ssc_auto_exec variables for SAM issue 1634 --------- Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov> Co-authored-by: Janine Keith <janinefreeman@users.noreply.github.com> Co-authored-by: tyneises <ty.neises@nrel.gov> Co-authored-by: Taylor Brown <60201147+taylorbrown75@users.noreply.github.com> Co-authored-by: Matt Prilliman <Matthew.Prilliman@nrel.gov> Co-authored-by: Matt Prilliman <54449384+mjprilliman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SAM Issue 1674: NatLabRockies/SAM#1674