Skip to content

Fix trough dispatch#1121

Merged
tyneises merged 7 commits into
patchfrom
fix-trough-dispatch
Jan 15, 2024
Merged

Fix trough dispatch#1121
tyneises merged 7 commits into
patchfrom
fix-trough-dispatch

Conversation

@tyneises

Copy link
Copy Markdown
Collaborator

Fixes SAM Issue 1674: NatLabRockies/SAM#1674

@tyneises tyneises merged commit d4dfcee into patch Jan 15, 2024
@tyneises tyneises deleted the fix-trough-dispatch branch January 15, 2024 16:58
@cpaulgilman cpaulgilman added this to the 2023 Release Patch 1 milestone Jan 29, 2024
tyneises pushed a commit that referenced this pull request Mar 15, 2024
)

* Add check for crit load unmet to self consumption metrics

* Correct size versus iprofile index for manual dispatch fuel cell and grid discharge arrays

* update git attributes file to correctly calculate language breakdown of project with linguist (#1119)

* Fix trough dispatch (#1121)

* define outputs required downstream

* move new outputs to design point section of cmod

* add sim_type required if to financial model inputs

* Add check to ensure trough_loop_control and nSCA agree

* Add check to IPH to ensure trough_loop_control and nSCA agree

* Remove nSCA as an input for CSP and IPH models. Add as design output.

---------

Co-authored-by: Taylor Brown <60201147+taylorbrown75@users.noreply.github.com>

* Remove overwriting of global variables in back surface irradiance calcs
for loss diagram metrics

* Use decomposed DNI when weather file DNI not available for allen
clipping correction

* Check irradiance mode before using dni decomp in allen method (i.e. is
code failing due to no dni provided)

* Address SAM issue 1676

* Fix GitHub Actions failing tests

* Fix failing macOS Github actions due to original root branch getem-cost-updates

* Test all previously failing tests on all platforms

* Reinstate all ssc tests for pull request approval

* Update REQUIRED_IF for ssc_auto_exec variables for SAM issue 1634

---------

Co-authored-by: Brian Mirletz <brian.mirletz@nrel.gov>
Co-authored-by: Janine Keith <janinefreeman@users.noreply.github.com>
Co-authored-by: tyneises <ty.neises@nrel.gov>
Co-authored-by: Taylor Brown <60201147+taylorbrown75@users.noreply.github.com>
Co-authored-by: Matt Prilliman <Matthew.Prilliman@nrel.gov>
Co-authored-by: Matt Prilliman <54449384+mjprilliman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants