Ensure weather data from new NSRDB endpoints downloaded in local time#950
Merged
Conversation
Set default NSRDB parameter utc=false so any new endpoints added in the future will hopefully be download in local time
brtietz
approved these changes
Feb 22, 2022
brtietz
left a comment
Collaborator
There was a problem hiding this comment.
Works great. Good thought with the future-proofing "else" statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add attributes list for new NSRDB Full Disc endpoint: https://developer.nrel.gov/docs/solar/nsrdb/full-disc-download/.
Set default NSRDB parameter in URL request
&utc=falseso any new endpoints added in the future will hopefully be download in local time.Note that this endpoint is not listed in the NSRDB API list at https://developer.nrel.gov/docs/solar/nsrdb/. I found it using a web search for "NSRDB API Full Disc."
Fixes #930
To test, build SAMnt_vs2019.sln in the SAM-private repository after building an open source version.
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.