Updated land area calculations for PV and PVWatts #928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpaulgilman
reviewed
Feb 10, 2022
Collaborator
cpaulgilman
left a comment
There was a problem hiding this comment.
This looks great!
A couple of comments:
For Detailed PV, the land area calculations use tilt for 2-axis and seasonal tilt option. For 2-axis, I think tilt = 0 would be appropriate assuming trackers rest in horizontal position, and for seasonal, the minimum tilt angle would be appropriate. (Two-axis trackers are not usually arranged in rows, so I'm not sure how useful the land estimate is for that option, but I think we can leave that for now.)
For PVWatts, the calcs use GCR even when it is disabled for 2-axis tracking. Perhaps GCR should be enabled for all tracking options with UI text for 2-axis tracking: "For 2-axis tracking, the ground coverage ratio is only used for land area calculations."
calculations; added gcr warning for PVWatts 2-axis tracking (still used for land area calcs)
cpaulgilman
reviewed
Feb 10, 2022
Collaborator
cpaulgilman
left a comment
There was a problem hiding this comment.
Seasonal tilt option does not work: Should be if ( ${subarray1_track_mode} == 4), etc., not 3.
cpaulgilman
approved these changes
Feb 10, 2022
cpaulgilman
added a commit
that referenced
this pull request
Feb 17, 2022
Revise description of load data time convention. Remove O&M cost content from Installation Costs topics. Add ETES topics and fix broken help links. Fix typo on battery storage FOM "BTM" insteasd of "FOM" Wind resource files can now be .csv in addition to .srw Revise capacity factor descriptions for PV and Battery storage configs, #905 Wave resource instructions for converting from time series to JPD, #892 Revise PV land area calculations to account for GCR and tilt angle, #928 Add pvlib column headings to SAM CSV format description, NREL/ssc#754 Revised Operating Cost input pages Check for "annual energy" vs new "electricity to grid". Change "battery autonomy" to "autonomy". Revise power tower heliostat field to better explain how check box vs button works. Add note for degradation by year that Year 1 value should be zero, #755 Remove debt from payback period description. Also remove detailed cash flow descriptions and replace with mention of send-to-Excel with equations and spreadsheets on website. See Amir Nashed email 1/19/21 and https://sam.nrel.gov/forum/forum-general/1052 Revise Electricity Purchases page to be specific for FOM projects New LCOS metrics: #529 Electricity rates revisions from Brian. Reporting of electricity bill in time series results, see NREL/ssc#652 New parametrics features Parametrics description of how to work with SchedNumeric variables like PPA price. See Brian email 7/21/2021 Update Heliostat Field per #717 New PV slope inputs on System Design page. See #742, NREL/ssc#648 New "Limit debt fraction" Input on Financial Parameters page for PPA models New ETES model. Fix outdated description of NSRDB in Location and Resource topic UDPC updates from Ty, see Revisions 2021 folder. Also post new PDF version of Ty and Matt's description under "CSP Power Cycle Models" on SAM website https://sam.nrel.gov/concentrating-solar-power/csp-publications.html, https://sam.nrel.gov/images/web_page_files/Neises-DRAFT-user-defined-power-cycle-v3-2018.pdf Fix excess generation descriptions in help: https://sam.nrel.gov/forum/forum-general/3485. Also maybe change "Excess generation" to "Excess generation for net metering" or similar. Note for URDB download that demand ratchet data in URDB is unreliable, so check with data sheet. Demand charges with ratcheting lookback months. See Revision Notes mirletz-RE Adding billing demand lookback to SAM.msg, see [[F:\OneDrive\SAM\Utility Rates\Demand Ratchets\Initial Tests May 2021]] Update pv smoothing per Steve's email 12/9/2021 "pv smoothing question" Improve description of FOM automated dispatch. See https://sam.nrel.gov/forum/forum-general/3681 Revise electricity rates page Consolidate weekday/weekend schedule descriptions. SWH remove old hot water draw import instructions. Revise electricity purchases PPA price option not available with Specify IRR target, and purchases treated as tax-deductible operating expense. Move electricity purchases page to from Battery section to Electricity Rates and Load section Edit Lifetime Data add note about pasting data from Excel: Thousands comma separator causes paste not to work correctly, e.g, 1,000 is pasted as 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-Account for horizontal projection of tilted arrays in land lease calculations.
-Calculate land area per subarray, sum to total land area
-Use default assumptions when shading parameters are not enabled, use shading layout when shading is enabled
-Use default assumptions always for PVWatts
-Needs documentation
Fixes #826
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.