Skip to content

Make JPD file from downloaded time series wave resource data #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjprilliman merged 19 commits into from
Feb 11, 2022
Merged

Make JPD file from downloaded time series wave resource data #892

mjprilliman merged 19 commits into from
Feb 11, 2022

Conversation

@mjprilliman
Copy link
Collaborator

@mjprilliman mjprilliman commented Jan 20, 2022

Description

Incorporating a requested for the wave model. Time series wave resource data is converted to a joint probability distribution (frequency of resource) file on download from the Wave API or on button press in the UI.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update (maybe)

@mjprilliman mjprilliman added this to the 2021.12.02 Patch 1 milestone Jan 20, 2022
@mjprilliman mjprilliman self-assigned this Jan 20, 2022
cpaulgilman
cpaulgilman requested changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I select an item in the library and click Make JPD File, nothing seems to happen. I expected it to convert the data and prompt me to save a JPD file, or tell me where it saved the JPD file.

  2. When I download a time series wave file (for 46.2,-124.2 in this case), SAM seems to communicate with the server, but I get this message and no file is added to my SAM Downloaded Weather Files folder:

image

  1. If I click Cancel in the download window, I get this UI callback error:
Could not evaluate callback function:btn_wave_download->on_change
[314]: reference to unassigned variable:fn
[314]:failed to evaluate function call argument number 0, value = fn
[289]: eval error in statement list
[289]: error inside function call
[146]: eval error in statement list
  1. The "SAM Downloaded Device Files" is the default folder for Wave Data Files. I think it should be SAM Downloaded Weather files, unless we want to create a new folder wave resource files.

image

  1. When I click Cancel from the Folder Settings window, I get this message:

image

Let me know if you'd like my help on any of these.

@mjprilliman
Copy link
Collaborator Author

mjprilliman commented Jan 24, 2022 •
edited
Loading

  1. When I select an item in the library and click Make JPD File, nothing seems to happen. I expected it to convert the data and prompt me to save a JPD file, or tell me where it saved the JPD file.
  2. When I download a time series wave file (for 46.2,-124.2 in this case), SAM seems to communicate with the server, but I get this message and no file is added to my SAM Downloaded Weather Files folder:

image

  1. If I click Cancel in the download window, I get this UI callback error:
Could not evaluate callback function:btn_wave_download->on_change
[314]: reference to unassigned variable:fn
[314]:failed to evaluate function call argument number 0, value = fn
[289]: eval error in statement list
[289]: error inside function call
[146]: eval error in statement list
  1. The "SAM Downloaded Device Files" is the default folder for Wave Data Files. I think it should be SAM Downloaded Weather files, unless we want to create a new folder wave resource files.

image

  1. When I click Cancel from the Folder Settings window, I get this message:

image

Let me know if you'd like my help on any of these.

Thanks for the feedback Paul. Notes below:

  1. I added a msgbox describing where the file was saved. Right now I have the process automated to save the jpd file in the same folder as the time series file. Do you think it should be a file save prompt instead?
  2. I think this been fixed in the latest commits. Let me know if you still have issues as I am not able to replicate them.
  3. Same as 2.
  4. I am unsure how these defaults are generated. It seems to have something to do with the 'wave_data_paths' but I do not see it hard-coded anywhere.
  5. What should the behavior be? The solar Folder Settings buttons have the same behavior.

@cpaulgilman
Copy link
Collaborator

cpaulgilman commented Jan 28, 2022

  1. This is resolved. I revised the text in my commit and edited the button labels to use sentence case (first letter of first word capitalized) instead of title case (every word capitalized).

  2. Resolved.

  3. Resolved.

  4. For the solar resource page, the "default" weather file download folder is defined in the fcall_wfdownloaddir() function in invoke.cpp:

    SAM/src/invoke.cpp

    Line 2469 in 54bf70f

    void fcall_wfdownloaddir( lk::invoke_t &cxt)
    . I think it would make sense to use the same folder for wave data so we don't create a bunch of folders on the user's computer.

  5. When you click Cancel in the folder settings window, it should just close without displaying a message. There is an if statement in the UI callback that displays this message in case SAM can't open the Folder Settings window for some reason. I think the solution is just to delete else { msgbox( 'Could not open window!\nSolar Resource Data Folder Settings window not available.' ); for the solar and wave resource callbacks. I did that in my commit to this branch.

Additional item:

  1. Does the wave resource page need two "Refresh library" buttons?

@mjprilliman
Copy link
Collaborator Author

mjprilliman commented Feb 10, 2022

Added bug fixes, label updates to this PR:
-Change sidebar label titles to match marine energy terminology
-Fixed label disappearing on ME Array page
-Changed blue bar wave resource switch to radio choice exclusive header page (label could use review)

@cpaulgilman cpaulgilman added the requires help revision Requires a Help revision before releasing public version label Feb 10, 2022
cpaulgilman
cpaulgilman approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I revised the text. I will update Help before we release Patch 1.

@mjprilliman mjprilliman merged commit 471e290 into patch Feb 11, 2022
@mjprilliman mjprilliman deleted the marine_jpdfile branch February 11, 2022 18:24
@cpaulgilman cpaulgilman removed the requires help revision Requires a Help revision before releasing public version label Feb 16, 2022
cpaulgilman added a commit that referenced this pull request Feb 17, 2022
@cpaulgilman
Help revisions for SAM 2020.12.02. r1
ccdd3ac 
Revise description of load data time convention.

Remove O&M cost content from Installation Costs topics.

Add ETES topics and fix broken help links.

Fix typo on battery storage FOM "BTM" insteasd of "FOM"

Wind resource files can now be .csv in addition to .srw

Revise capacity factor descriptions for PV and Battery storage configs, #905

Wave resource instructions for converting from time series to JPD, #892

Revise PV land area calculations to account for GCR and tilt angle, #928

Add pvlib column headings to SAM CSV format description, NREL/ssc#754

Revised Operating Cost input pages

Check for "annual energy" vs new "electricity to grid".

Change "battery autonomy" to "autonomy".

Revise power tower heliostat field to better explain how check box vs button works.

Add note for degradation by year that Year 1 value should be zero, #755

Remove debt from payback period description. Also remove detailed cash flow descriptions and replace with mention of send-to-Excel with equations and spreadsheets on website. See Amir Nashed email 1/19/21 and https://sam.nrel.gov/forum/forum-general/1052

Revise Electricity Purchases page to be specific for FOM projects

New LCOS metrics: #529

Electricity rates revisions from Brian.

Reporting of electricity bill in time series results, see NREL/ssc#652

New parametrics features

Parametrics description of how to work with SchedNumeric variables like PPA price. See Brian email 7/21/2021

Update Heliostat Field per #717

New PV slope inputs on System Design page. See #742, NREL/ssc#648

New "Limit debt fraction" Input on Financial Parameters page for PPA models

New ETES model.

Fix outdated description of NSRDB in Location and Resource topic

UDPC updates from Ty, see Revisions 2021 folder. Also post new PDF version of Ty and Matt's description under "CSP Power Cycle Models"  on SAM website https://sam.nrel.gov/concentrating-solar-power/csp-publications.html,  https://sam.nrel.gov/images/web_page_files/Neises-DRAFT-user-defined-power-cycle-v3-2018.pdf

Fix excess generation descriptions in help: https://sam.nrel.gov/forum/forum-general/3485. Also maybe change "Excess generation" to "Excess generation for net metering" or similar.

Note for URDB download that demand ratchet data in URDB is unreliable, so check with data sheet.

Demand charges with ratcheting lookback months. See Revision Notes mirletz-RE Adding billing demand lookback to SAM.msg, see [[F:\OneDrive\SAM\Utility Rates\Demand Ratchets\Initial Tests May 2021]]

Update pv smoothing per Steve's email 12/9/2021 "pv smoothing question"

Improve description of FOM automated dispatch. See https://sam.nrel.gov/forum/forum-general/3681

Revise electricity rates page

Consolidate weekday/weekend schedule descriptions.

SWH remove old hot water draw import instructions.

Revise electricity purchases PPA price option not available with Specify IRR target, and purchases treated as tax-deductible operating expense.

Move electricity purchases page to from Battery section to Electricity Rates and Load section

Edit Lifetime Data add note about pasting data from Excel: Thousands comma separator causes paste not to work correctly, e.g, 1,000 is pasted as 1.
@cpaulgilman cpaulgilman mentioned this pull request Feb 17, 2022
Merged
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpaulgilman cpaulgilman cpaulgilman approved these changes

Assignees

@mjprilliman mjprilliman

Labels

added to release notes PR and/or issue has been added to release notes for a public release new feature

Projects

None yet

Milestone

2021.12.02 Patch 1

Development

Successfully merging this pull request may close these issues.

3 participants

@mjprilliman @cpaulgilman