Update PV PDF report templates#1789
Merged
Merged
Conversation
sjanzou
approved these changes
Jun 12, 2024
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and the footer provides nice information
dguittet
added a commit
that referenced
this pull request
Jun 25, 2024
* Update lhs.bin and stepwise.bin to address #1417 * Not sure why GitHub Actions failing when Mac binaries only thing updated * Fix base branch for GitHub Actions - patch * Rerun defaults on Windows for failing GitHub Actions * Fix indifference point macro description (#1788) * Update PV PDF report templates (#1789) * Fix Federal depreciation calculation in host_developer.xlsx (#1793) Cell CashFlow!B398 incorrectly referred to $C$141 for federal custom depreciation allocation which caused divide by zero errors that propagated through workbook all the way to LCOE and NPV results. This issue only affected Host Developer send-to-Excel with equations when 20-yr SL allocation (Inputs!C141) is set to zero. Checked that all other FOM spreadsheets do not have this problem. * UI message for battery grid charging with PBI (#1792) Also trigger message on_change so message appears when you switch to Battery Dispatch pages. * Marine Energy documentation revisions (#1790) * Fix base branch in Github CI (#1779) * fix base branch * fix ref name * set default branch to patch * update test results --------- Co-authored-by: sjanzou <sjanzou@gmail.com> Co-authored-by: Steven Janzou <steven@janzouconsulting.com> Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
dguittet
added a commit
that referenced
this pull request
Jun 25, 2024
* Update lhs.bin and stepwise.bin to address #1417 * Not sure why GitHub Actions failing when Mac binaries only thing updated * Fix base branch for GitHub Actions - patch * Rerun defaults on Windows for failing GitHub Actions * Fix indifference point macro description (#1788) * Update PV PDF report templates (#1789) * Update PV Tracking and Orientation diagram Old version was misleading for one-axis trackers. Delete extra copies of image file. * Update documentation for PV tracking and orientation * Revise PVWatts tilt and azimuth descriptions * Fix Federal depreciation calculation in host_developer.xlsx (#1793) Cell CashFlow!B398 incorrectly referred to $C$141 for federal custom depreciation allocation which caused divide by zero errors that propagated through workbook all the way to LCOE and NPV results. This issue only affected Host Developer send-to-Excel with equations when 20-yr SL allocation (Inputs!C141) is set to zero. Checked that all other FOM spreadsheets do not have this problem. * UI message for battery grid charging with PBI (#1792) Also trigger message on_change so message appears when you switch to Battery Dispatch pages. * Marine Energy documentation revisions (#1790) * Fix base branch in Github CI (#1779) * fix base branch * fix ref name * set default branch to patch * Address hybrid SAM lk scripting issues in #1636 * Squashed commit of the following: commit c5f39d5 Author: Paul Gilman <cpaulgilman@gmail.com> Date: Fri Jun 14 16:13:53 2024 -0700 Fix CEC Help topic commit d44d433 Author: Paul Gilman <cpaulgilman@gmail.com> Date: Fri Jun 14 16:00:05 2024 -0700 Help revisions for PV temperature, spectral, and optical models * Revise IEC 61853 topic to explain temperature, spectral, and optical models. * Add note for CEC model to explain air mass model. commit 05581df Author: Paul Gilman <cpaulgilman@gmail.com> Date: Fri Jun 14 15:58:13 2024 -0700 UI fixes for PV optical and spectral models * Display all available data for Sandia module model so users can see model coefficient values in UI without opening library CSV file. * Improve labeling of inputs for IEC 61853 module model * Improve Documentation of IEC 61858 temperature, optical, and spectral models (#1795) * UI fixes for PV optical and spectral models * Display all available data for Sandia module model so users can see model coefficient values in UI without opening library CSV file. * Improve labeling of inputs for IEC 61853 module model * Help revisions for PV temperature, spectral, and optical models * Revise IEC 61853 topic to explain temperature, spectral, and optical models. * Add note for CEC model to explain air mass model. * Fix CEC Help topic * Improve lk select_inputs() function description * revert test_results_win64.csv --------- Co-authored-by: sjanzou <sjanzou@gmail.com> Co-authored-by: Steven Janzou <steven@janzouconsulting.com> Co-authored-by: Paul Gilman <cpaulgilman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address PV PDF report template requests to fix #1670. Affects PDF report for Detailed PV, PV Battery, PVWatts, and PVWatts Battery configurations.
Fix PVWatts dc_adj bug.
Weather file used: Weather file string is too long to fit in header. Show data source, e.g., "NSRDB" instead.
Model name and number of user-specified solar modules (when using the user-entered, not database), ditto for inverters: Done. Note that inverter with user-specs does not have a field for inverter name.
Module total capacity in kW, not MW, or both: The report generator script displays module and system capacity in W, kW, or MW depending on system size. Keep this behavior.
Inverter nominal output AC voltage (very important): Done.
Number of strings per inverter (total number of strings divided by number of inverters): This information does not reflect how the model works, and can easily be calculated from info on report, so omitting this request.
Module orientation (portrait or landscape): Not enough space in table.
Albedo: Not enough space in table.
GCR (very important): Done
Distance between rows (bottom of one to bottom of next): Not enough space in table.
Total estimated land area (not just for the modules, but projected onto ground + any additional land specified): Not enough space in table.
Net to grid figure not rounded to nearest 1,000 kWh, but exactly as printed on the bottom of page 3, so they agree: Done
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.