-
Notifications
You must be signed in to change notification settings - Fork 222
V25.2.0-IOFreeze: new ThermalStorageChilledWaterStratified default #5495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
| * [#5495](https://github.com/NREL/OpenStudio/pull/5495) - New ThermalStorageChilledWaterStratified default | ||
| * Field `Nominal Cooling Capacity` is made required (also made autosizable) for `ThermalStorage:ChilledWater:Stratified` | ||
| * API-breaking change for `ThermalStorage:ChilledWater:Stratified`: | ||
| * `resetNominalCoolingCapacity` is removed |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this instead be deprecated (to do nothing)? Seems dangerous.
Collaborator
|
CI Results for 10b91dd:
|
10b91dd to
5c461cd
Compare
5c461cd to
c9235ad
Compare
jmarrec
approved these changes
Oct 20, 2025
19 tasks
jmarrec
added a commit
that referenced
this pull request
Nov 13, 2025
#5495 follow up - Add a WaterHeater:Sizing to ThermalStorage:ChilledWater:Stratified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
IDDChange
Pull Request - Ready for CI
This pull request if finalized and is ready for continuous integration verification prior to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.