Skip to content

Conversation

@joseph-robertson
Copy link
Collaborator

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson self-assigned this Oct 9, 2025
@joseph-robertson joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Oct 9, 2025
@joseph-robertson joseph-robertson mentioned this pull request Oct 9, 2025
26 tasks
* [#5495](https://github.com/NREL/OpenStudio/pull/5495) - New ThermalStorageChilledWaterStratified default
* Field `Nominal Cooling Capacity` is made required (also made autosizable) for `ThermalStorage:ChilledWater:Stratified`
* API-breaking change for `ThermalStorage:ChilledWater:Stratified`:
* `resetNominalCoolingCapacity` is removed
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this instead be deprecated (to do nothing)? Seems dangerous.

@ci-commercialbuildings
Copy link
Collaborator

ci-commercialbuildings commented Oct 16, 2025

CI Results for 10b91dd:

@joseph-robertson joseph-robertson marked this pull request as ready for review October 16, 2025 16:10
Base automatically changed from v25.2.0-IOFreeze to develop October 20, 2025 12:08
@jmarrec jmarrec force-pushed the v25.2.0-IOFreeze-ts-cw branch from 10b91dd to 5c461cd Compare October 20, 2025 12:15
@jmarrec jmarrec force-pushed the v25.2.0-IOFreeze-ts-cw branch from 5c461cd to c9235ad Compare October 20, 2025 12:18
@jmarrec jmarrec merged commit 11a0718 into develop Oct 20, 2025
2 of 6 checks passed
@jmarrec jmarrec deleted the v25.2.0-IOFreeze-ts-cw branch October 20, 2025 12:20
jmarrec added a commit that referenced this pull request Nov 13, 2025
#5495 follow up - Add a WaterHeater:Sizing to ThermalStorage:ChilledWater:Stratified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants