-
Notifications
You must be signed in to change notification settings - Fork 222
#5495 follow up - Add a WaterHeater:Sizing to ThermalStorage:ChilledWater:Stratified #5509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we decided that the ctor for Nominal Cooling Capacity should be autosized? If so, don't we need to update VT to create a WaterHeater:Sizing object in the event the field was blank (i.e., gets autosized)?
Edit: should the ctor behavior be the same as the VT behavior? Meaning, would it make sense to have blank -> 0.0 in VT but autosize in the ctor?
Seems like VT should maintain the old behavior, so I'm setting blank Nominal Cooling Capacity to 0.0. 8f1c594 |
joseph-robertson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are good with the recent VT change I made, I think this PR is ready to drop in?
…t to the ThermalSto:Chw:Strat object
I think I want the VT to actually add a WaterHeaterSizing, I overlooked that, but your change made me think about it, thanks! Will do just now, let CI take a pass on it, and then it can merge. |
8f1c594 to
be50ce1
Compare
|
CI Results for be50ce1:
|
Pull request overview
@joseph-robertson
Please watch this:
In case someone actually says it isn't supported, but I'm leaning towards it being required.
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.