Update sample configuration and documentation#91
Merged
mattyjones merged 1 commit intoN0MoreSecr3ts:developfrom Feb 12, 2021
Merged
Update sample configuration and documentation#91mattyjones merged 1 commit intoN0MoreSecr3ts:developfrom
mattyjones merged 1 commit intoN0MoreSecr3ts:developfrom
Conversation
Update the yaml configuration file example, as well as the description in step 1 and the yaml example in the README.md file. According to implementations found in scanLocalGitRepo.go:69 and scanLocalPath.go:85, the sample.yml and the quickstart instructions weren't referring to the updated parameter names.
Collaborator
|
@sgobotta Thanks for catching this. Documentation is always the last thing updated. |
mattyjones
added a commit
that referenced
this pull request
Apr 4, 2021
* clean up flags * update * update * update flag strings * formating issues * webserver enable/disable flaf * enhanced debug and header output * csv and json output * bring in ability to update signatures to a specific version * Update sample configuration and documentation (#91) Update the yaml configuration file example, as well as the description in step 1 and the yaml example in the README.md file. According to implementations found in scanLocalGitRepo.go:69 and scanLocalPath.go:85, the sample.yml and the quickstart instructions weren't referring to the updated parameter names. * cleanup * fix the progress bar Still not quite right due to threads but better * remove dead functions * Updated the changelog * implement persistent flags (#95) move the flags that are common to all the commands into the root command. The updateRules command does not adhere to all the flags but for know we will deal with it. Signed-off-by: Matty <urlugal@gmail.com> Co-authored-by: Santiago Botta <sgobotta@gmail.com> Co-authored-by: Matty <matty.j@innocentlivesfoundation.org>
mattyjones
added a commit
that referenced
this pull request
Apr 5, 2021
* clean up flags * update * update * update flag strings * formating issues * webserver enable/disable flaf * enhanced debug and header output * csv and json output * bring in ability to update signatures to a specific version * Update sample configuration and documentation (#91) Update the yaml configuration file example, as well as the description in step 1 and the yaml example in the README.md file. According to implementations found in scanLocalGitRepo.go:69 and scanLocalPath.go:85, the sample.yml and the quickstart instructions weren't referring to the updated parameter names. * cleanup * fix the progress bar Still not quite right due to threads but better * remove dead functions * Updated the changelog * implement persistent flags move the flags that are common to all the commands into the root command. The updateRules command does not adhere to all the flags but for know we will deal with it. Signed-off-by: Matty <urlugal@gmail.com> * Cleanup Signed-off-by: Matty <urlugal@gmail.com> * implement persistent flags (#95) move the flags that are common to all the commands into the root command. The updateRules command does not adhere to all the flags but for know we will deal with it. Signed-off-by: Matty <urlugal@gmail.com> Co-authored-by: Santiago Botta <sgobotta@gmail.com> Co-authored-by: Matty <matty.j@innocentlivesfoundation.org>
Contributor
Author
Glad to contribute 👌 |
mattyjones
added a commit
that referenced
this pull request
Apr 29, 2021
* Develop (#97) * clean up flags * update * update * update flag strings * formating issues * webserver enable/disable flaf * enhanced debug and header output * csv and json output * bring in ability to update signatures to a specific version * Update sample configuration and documentation (#91) Update the yaml configuration file example, as well as the description in step 1 and the yaml example in the README.md file. According to implementations found in scanLocalGitRepo.go:69 and scanLocalPath.go:85, the sample.yml and the quickstart instructions weren't referring to the updated parameter names. * cleanup * fix the progress bar Still not quite right due to threads but better * remove dead functions * Updated the changelog * implement persistent flags move the flags that are common to all the commands into the root command. The updateRules command does not adhere to all the flags but for know we will deal with it. Signed-off-by: Matty <urlugal@gmail.com> * Cleanup Signed-off-by: Matty <urlugal@gmail.com> * implement persistent flags (#95) move the flags that are common to all the commands into the root command. The updateRules command does not adhere to all the flags but for know we will deal with it. Signed-off-by: Matty <urlugal@gmail.com> Co-authored-by: Santiago Botta <sgobotta@gmail.com> Co-authored-by: Matty <matty.j@innocentlivesfoundation.org> * bump version and update changelog * Update CHANGELOG.md * Adding github-enterprise-url, fixing auth, fixing standard vs. enterprise org/repo/user param differentiation, fixing expaand-orgs mispelling Co-authored-by: Matt Jones <mattyjones@users.noreply.github.com> Co-authored-by: Santiago Botta <sgobotta@gmail.com> Co-authored-by: Matty <matty.j@innocentlivesfoundation.org> Co-authored-by: Matty <urlugal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides:
sample.ymlupdate.README.mdMotivation
The documentation and sample configuration file seemed to be out of date in contrast to the implementation in
localPath.goandlocalRepo.go.