Merged
Conversation
Update the yaml configuration file example, as well as the description in step 1 and the yaml example in the README.md file. According to implementations found in scanLocalGitRepo.go:69 and scanLocalPath.go:85, the sample.yml and the quickstart instructions weren't referring to the updated parameter names.
Still not quite right due to threads but better
move the flags that are common to all the commands into the root command. The updateRules command does not adhere to all the flags but for know we will deal with it. Signed-off-by: Matty <urlugal@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=========================================
- Coverage 0.81% 0.79% -0.03%
=========================================
Files 17 17
Lines 1840 1892 +52
=========================================
Hits 15 15
- Misses 1825 1877 +52
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.