Skip to content

[graphql-alt] Update Query return types for partial error support [8/n]#25110

Merged
tpham-mysten merged 1 commit intomainfrom
tpham-partial-error-query
Jan 30, 2026
Merged

[graphql-alt] Update Query return types for partial error support [8/n]#25110
tpham-mysten merged 1 commit intomainfrom
tpham-partial-error-query

Conversation

@tpham-mysten
Copy link
Copy Markdown
Contributor

Description

Updates Query return types from Result<Option<T>, E> to Option<Result<T, E>> for partial error support.

Files changed:

  • crates/sui-indexer-alt-graphql/src/api/query.rs

Test plan

How did you test the new or updated feature?

cargo nextest run -p sui-indexer-alt-e2e-tests

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL: Partial error will be properly supported in GraphQL. Invalid fields will have error messages and valid fields will still be displayed normally
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sui-docs Ready Ready Preview, Comment Jan 30, 2026 6:59am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
multisig-toolkit Ignored Ignored Preview Jan 30, 2026 6:59am
sui-kiosk Ignored Ignored Preview Jan 30, 2026 6:59am

Request Review

@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 26, 2026 21:57 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-query branch from eb08bc3 to 4deb04d Compare January 30, 2026 02:11
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 02:11 — with GitHub Actions Inactive
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Jan 30, 2026
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-coinmetadata-dynamicfield branch from 051d362 to 9751a3b Compare January 30, 2026 02:15
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-query branch from 4deb04d to 598c62a Compare January 30, 2026 02:35
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 02:35 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Type: Documentation Improvements or additions to documentation label Jan 30, 2026
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-coinmetadata-dynamicfield branch from 82199c8 to fb1f145 Compare January 30, 2026 03:06
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-query branch from 598c62a to 0bb95ba Compare January 30, 2026 03:16
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 03:16 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-query branch from 0bb95ba to ffebe9b Compare January 30, 2026 03:20
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 03:20 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-coinmetadata-dynamicfield branch 2 times, most recently from 6262731 to 5514ff5 Compare January 30, 2026 03:55
Base automatically changed from tpham-partial-error-coinmetadata-dynamicfield to main January 30, 2026 04:19
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-query branch from ffebe9b to 47bbbab Compare January 30, 2026 04:23
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 04:23 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-query branch from 47bbbab to 412db04 Compare January 30, 2026 05:36
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 05:36 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-query branch from 412db04 to 50047bc Compare January 30, 2026 06:14
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 06:14 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-query branch from 50047bc to a0684cd Compare January 30, 2026 06:55
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 06:55 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten merged commit 89be7da into main Jan 30, 2026
73 of 74 checks passed
@tpham-mysten tpham-mysten deleted the tpham-partial-error-query branch January 30, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants