Skip to content

[graphql-alt] Update IMoveObject/MoveObject/CoinMetadata/DynamicField return types for partial error support [7/n]#25109

Merged
tpham-mysten merged 2 commits intomainfrom
tpham-partial-error-coinmetadata-dynamicfield
Jan 30, 2026
Merged

[graphql-alt] Update IMoveObject/MoveObject/CoinMetadata/DynamicField return types for partial error support [7/n]#25109
tpham-mysten merged 2 commits intomainfrom
tpham-partial-error-coinmetadata-dynamicfield

Conversation

@tpham-mysten
Copy link
Copy Markdown
Contributor

@tpham-mysten tpham-mysten commented Jan 26, 2026

Description

Updates IMoveObject interface and its implementors (MoveObject, CoinMetadata, DynamicField) return types from Result<Option<T>, E> to Option<Result<T, E>> for partial error support.

Files changed:

  • crates/sui-indexer-alt-graphql/src/api/types/move_object.rs
  • crates/sui-indexer-alt-graphql/src/api/types/coin_metadata.rs
  • crates/sui-indexer-alt-graphql/src/api/types/dynamic_field.rs

Test plan

How did you test the new or updated feature?

cargo nextest run -p sui-indexer-alt-e2e-tests

Stack

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL: Partial error will be properly supported in GraphQL. Invalid fields will have error messages and valid fields will still be displayed normally
  • CLI:
  • Rust SDK:
  • Indexing Framework:

@tpham-mysten tpham-mysten requested a review from a team as a code owner January 26, 2026 21:55
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 26, 2026 21:55 — with GitHub Actions Inactive
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sui-docs Ready Ready Preview, Comment Jan 30, 2026 3:59am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
multisig-toolkit Ignored Ignored Preview Jan 30, 2026 3:59am
sui-kiosk Ignored Ignored Preview Jan 30, 2026 3:59am

Request Review

Base automatically changed from tpham-partial-error-service-config to main January 28, 2026 03:22
… return types for partial error support [7/n]
@tpham-mysten tpham-mysten force-pushed the tpham-partial-error-coinmetadata-dynamicfield branch from 6262731 to 5514ff5 Compare January 30, 2026 03:55
@tpham-mysten tpham-mysten temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2026 03:55 — with GitHub Actions Inactive
@tpham-mysten tpham-mysten merged commit e29815c into main Jan 30, 2026
56 of 58 checks passed
@tpham-mysten tpham-mysten deleted the tpham-partial-error-coinmetadata-dynamicfield branch January 30, 2026 04:19
tpham-mysten added a commit that referenced this pull request Jan 30, 2026
…n] (#25110)

## Description 

Updates `Query` return types from `Result<Option<T>, E>` to
`Option<Result<T, E>>` for partial error support.

Files changed:
  - crates/sui-indexer-alt-graphql/src/api/query.rs

## Test plan 

How did you test the new or updated feature?

```
cargo nextest run -p sui-indexer-alt-e2e-tests
```

---

- #24595
- #24681 
- #24682 
- #24683 
- #24684 
- #25108 
- #25109
- #25110 ⬅️

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [x] GraphQL: Partial error will be properly supported in GraphQL.
Invalid fields will have error messages and valid fields will still be
displayed normally
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] Indexing Framework:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants