Skip to content

merge upstream#15

Merged
jsboige merged 4 commits intoMyIntelligenceAgency:mainfrom
microsoft:main
Jul 7, 2023
Merged

merge upstream#15
jsboige merged 4 commits intoMyIntelligenceAgency:mainfrom
microsoft:main

Conversation

@jsboige
Copy link

@jsboige jsboige commented Jul 7, 2023

Motivation and Context

Description

Contribution Checklist

MixeroTN and others added 4 commits July 6, 2023 16:27
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

`README.md` had several visual problems, which I decided to fix.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

- The first problem was a `dotnet-ci` status badge, which is no longer
available. I replaced it with two status badges: `dotnet-ci-docker` and
`dotnet-ci-windows`.
- The second one was *Using Semantic Kernel in C# and Python*. The icons
were positioned out of place. I have made a small table with the icons
and hyperlinks present earlier.
- And finally, small corrections such as h3 lines for C# and Python
approaches above *getting started with the basics* instructions.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Fixes #1788

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Correct the part of the deploy scripts that updates the redirect URI.
The previously used command only works for the "web" platform type, not
"SPA" which Copilot Chat uses. Azure CLI does not support the latter, so
using `az rest` instead.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Many Copilot Chat app React components call getActiveAccount() to get
the logged in user id/name as one of the setup steps. This will trigger
MSAL to retrieve ID tokens from the cache, resulting in unnecessary
calls to getIdToken as shown below.


![24cfecf0-4896-4561-98ba-3b65a9947c5a](https://github.com/microsoft/semantic-kernel/assets/12570346/f726cf97-fdf3-4913-a5a7-2f13a85cc04e)

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Cache the logged in user id/name in the Redux store so that components
don't have to repeatedly call getActiveAccount().

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
Co-authored-by: Desmond Howard <dehoward@microsoft.com>
Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com>
Copilot Chat's .net project builds, runs, works just fine when opened
from the `CopilotChatWebApi.csproj` directly. Every time you open this
project, however, VS kindly creates a new .sln for you and offers to
save it.

This just creates a convenient .sln that one can open. This can also be
used by dotnet format and build scripts. It contains just the one
`CopilotChatWebApi` project right now, but it's placed in the
copilot-chat folder so that additional projects (tests, extensions,
etc.) could be added in the future.
@jsboige jsboige merged commit 7ac17e8 into MyIntelligenceAgency:main Jul 7, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation samples copilot chat labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot chat documentation Improvements or additions to documentation samples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants