Copilot Chat: Fix redirect URI update in deploy scripts#1860
Merged
gitri-ms merged 8 commits intomicrosoft:mainfrom Jul 6, 2023
Merged
Copilot Chat: Fix redirect URI update in deploy scripts#1860gitri-ms merged 8 commits intomicrosoft:mainfrom
gitri-ms merged 8 commits intomicrosoft:mainfrom
Conversation
glahaye
reviewed
Jul 5, 2023
amsacha
previously approved these changes
Jul 5, 2023
gitri-ms
commented
Jul 5, 2023
glahaye
previously approved these changes
Jul 6, 2023
teresaqhoang
previously approved these changes
Jul 6, 2023
shawncal
previously approved these changes
Jul 6, 2023
gitri-ms
commented
Jul 6, 2023
9774e88
glahaye
approved these changes
Jul 6, 2023
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fixes microsoft#1788 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Correct the part of the deploy scripts that updates the redirect URI. The previously used command only works for the "web" platform type, not "SPA" which Copilot Chat uses. Azure CLI does not support the latter, so using `az rest` instead. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1788
Description
Correct the part of the deploy scripts that updates the redirect URI. The previously used command only works for the "web" platform type, not "SPA" which Copilot Chat uses. Azure CLI does not support the latter, so using
az restinstead.Contribution Checklist
dotnet format