Copilot Chat: Reduce calls to MSAL getIdToken#1612
Merged
gitri-ms merged 12 commits intomicrosoft:mainfrom Jul 6, 2023
Merged
Conversation
amsacha
suggested changes
Jun 20, 2023
dehoward
reviewed
Jun 20, 2023
samples/apps/copilot-chat-app/webapp/src/redux/features/conversations/ConversationsState.ts
Outdated
Show resolved
Hide resolved
dehoward
reviewed
Jun 20, 2023
dehoward
previously approved these changes
Jun 20, 2023
teresaqhoang
previously approved these changes
Jun 20, 2023
samples/apps/copilot-chat-app/webapp/src/redux/features/app/AppState.ts
Outdated
Show resolved
Hide resolved
dehoward
reviewed
Jun 20, 2023
amsacha
previously approved these changes
Jun 20, 2023
274976e
amsacha
previously approved these changes
Jun 26, 2023
dehoward
reviewed
Jun 27, 2023
dehoward
previously approved these changes
Jun 27, 2023
teresaqhoang
previously approved these changes
Jun 30, 2023
|
resolving conflicts |
c1f0289
dehoward
approved these changes
Jun 30, 2023
amsacha
approved these changes
Jul 3, 2023
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Many Copilot Chat app React components call getActiveAccount() to get the logged in user id/name as one of the setup steps. This will trigger MSAL to retrieve ID tokens from the cache, resulting in unnecessary calls to getIdToken as shown below.  ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Cache the logged in user id/name in the Redux store so that components don't have to repeatedly call getActiveAccount(). ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com> Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com> Co-authored-by: Desmond Howard <dehoward@microsoft.com> Co-authored-by: Aman Sachan <51973971+amsacha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Many Copilot Chat app React components call getActiveAccount() to get the logged in user id/name as one of the setup steps. This will trigger MSAL to retrieve ID tokens from the cache, resulting in unnecessary calls to getIdToken as shown below.
Description
Cache the logged in user id/name in the Redux store so that components don't have to repeatedly call getActiveAccount().
Contribution Checklist
dotnet format