Edbee editor implementation, take two by tomcss · Pull Request #985 · Mudlet/Mudlet

tomcss · 2017-05-01T14:28:23Z

It requires two files in ~/.config/mudlet/edbee, the syntax file and the theme. You can just unzip the following file in ~/.config/mudlet :

edbee.zip

--

Some of the comments showed up as changed with an extra space. I really don't know why - I didn't touch them manually.

SlySven

To allow the project to compile I think you will have to add the Edbee source files into our (recently fitted) 3rdParty sub-directory and add the build instructions to the qmake (top level /src/src.pro and additional .pro files in sub-directories for 3rd party items) and cmake (CMakeList.txt files in main and sub-directories) project build systems...

... our Travis C.I. setup may need tweaking - although adding the source files and emending/supplementing the project files in may be sufficient

SlySven · 2017-05-01T16:48:59Z

src/dlgTriggerEditor.cpp

    mpTriggersMainArea->lineEdit_trigger_name->clear();
    mpTriggersMainArea->perlSlashGOption->setChecked( false );
-    mpSourceEditor->clear();
+    mpSourceEditorEdbeeDocument->setText("");


It doesn't have a clear() method to remove the contents?
Please avoid using raw string literals {we will only have to go through later and mark whether they are part of the UI and need marking as something that has to be translated (or not) for Mudlet 4.0...} - I'd suggest the following:

mpSourceEditorEdbeeDocument->setText(QString());

There isn't a clear. http://docs.edbee.net/html/classedbee_1_1_text_document.html

SlySven · 2017-05-01T16:53:57Z

src/ui/source_editor_area.ui

+       <verstretch>0</verstretch>
+      </sizepolicy>
+     </property>
+     <property name="font">


Do you have to specify a font here - if you omit this won't it inherit the parent widget's font - or are you looking to override that here?

SlySven · 2017-05-01T16:59:29Z

src/dlgTriggerEditor.cpp

-    _options.setFlags( _flags );
-    mpSourceEditorDocument->setDefaultTextOption( _options );
-
-    connect( mpSourceEditor, SIGNAL( cursorPositionChanged() ), this, SLOT( slot_cursorPositionChanged() ) );


You are removing the cursor positioning data from the status bar - does the new widget provide the same sort of information from it's updateStatusTextSignal SIGNAL?

Cursor positioning isn't necessary anymore because this widget actually has line numbers!

ahmedcharles · 2017-05-01T19:23:29Z

src/dlgTriggerEditor.h

    void slot_color_trigger_fg();
    void slot_color_trigger_bg();

+    void slot_updateStatusBar( const QString statusText); // For the source code editor


This should probably be const QString& statusText.

SlySven · 2017-05-02T19:54:25Z

Speaking as someone who is currently hitting the issue face on, how well does this editor widget behave in the presence of non-BMP "characters" or other non-normal things in the text?

I see, for instance in that linked to documentation: "charAtOrNull(int idx) - returns the char at the given index if the index is valid else the null character is returned" and I wonder what happens if the QChar concerned is a low-surrogate?

Or, I read: "columnFromOffsetAndLine(int offset, int line = -1) return the column position for the given offset and line, where offset is the offset position and lineis "the line number which contains this offset. (When -1 the line number is calculated)" and I start to think, "maybe this will work so that if I ask at what column is the 10th QChar on that line in and it is a combining diacritical e.g. U+035D {COMBINING DOUBLE BREVE} will that tell me that it is part of the eighth grapheme on that line..."!

This is a really evil test passage that I have lifted from Stack Exchange: http://stackoverflow.com/a/1732454/4805858 to exercise things to the extreme, the tail end of which, when written as a single single appears thus in the current editor:

and when display with the code I am working on in another PR:

How well does Edbee work with this, I wonder - 😈 ?

…-includes

…let.pro

SlySven · 2017-05-05T15:47:28Z

You are making some headway - 2 out of 6 Travis C.I. builds are now completing those being the Linux - Qmake ones (both using Clang and gcc) that just leaves the CMake for Linux builds and the MacOS ones to sort out - the CMake on BOTH platforms is having problems with the includes:

/Users/travis/build/Mudlet/Mudlet/src/dlgSourceEditorArea.h:27:10: fatal error: 'edbee/edbee.h' file not found
#include "edbee/edbee.h"
     ^

whilst the qmake one on MacOS that platform is having 3 problems because a compare(...) method is ambiguous, the first occurrence being:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -c -pipe -stdlib=libc++ -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -mmacosx-version-min=10.9  -O2 -fPIC -std=gnu++11 -Wall -W -DDLL -DQS_LOG_LINE_NUMBERS_SHORT -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I../../../../3rdparty/edbee-lib/edbee-lib -I. -I../../../../3rdparty/edbee-lib/edbee-lib -I../../../../3rdparty/edbee-lib/edbee-lib -I../../../../3rdparty/edbee-lib/vendor/qslog -I../../../../3rdparty/edbee-lib/vendor/onig -I/usr/local/Cellar/qt/5.8.0_2/lib/QtWidgets.framework/Headers -I/usr/local/Cellar/qt/5.8.0_2/lib/QtGui.framework/Headers -I/usr/local/Cellar/qt/5.8.0_2/lib/QtCore.framework/Headers -I. -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/OpenGL.framework/Headers -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/AGL.framework/Headers -I/usr/local/Cellar/qt/5.8.0_2/mkspecs/macx-clang -F/usr/local/Cellar/qt/5.8.0_2/lib -o jsonparser.o ../../../../3rdparty/edbee-lib/edbee-lib/edbee/io/jsonparser.cpp
../../../../3rdparty/edbee-lib/edbee-lib/edbee/io/baseplistparser.cpp:118:26: error: call to member function 'compare' is ambiguous
if( xml_->name().compare( "dict", Qt::CaseInsensitive ) == 0 ) {    
        ~~~~~~~~~~~~~^~~~~~~`

(it also has a warning about something else in the editor library code as well...!)

Hope that helps - for the full gory details click on the "Details" link on the:
continuous-integration/travis-ci/pr — The Travis CI build failed Required Details line...

keneanung · 2017-05-05T15:56:19Z

We've been in contact over discord for the compile stuff:

The macOS stuff seems to be an issue of Qt 5.8, we should probably make at least an upstream bug report, if not propose fixes.
We didn't touch cmake builds yet, especially since the edbee project needs CMakeLists.txt files made
I'm also annoyed about the thousands of warnings in the library, but we're looking at turning warnings off for that.

vadi2 · 2017-05-05T16:29:02Z

Awesome work guys! Keep us posted on the 5.8 support - we must have faith in any library we adopt that it'll work for us going into the future.

…

On Fri, 5 May 2017 5:56 pm keneanung, ***@***.***> wrote: We've been in contact over discord for the compile stuff: - The macOS stuff seems to be an issue of Qt 5.8, we should probably make at least an upstream bug report, if not propose fixes. - We didn't touch cmake builds yet, especially since the edbee project needs CMakeLists.txt files made - I'm also annoyed about the thousands of warnings in the library, but we're looking at turning warnings off for that. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#985 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGxjJUtlxSF4rjW9mLDVsy0c8dFYOAKks5r20akgaJpZM4NNFOy> .

…re overloads than 5.6

tomcss · 2017-05-05T19:05:43Z

To answer Sven's question about unicode.

When using your supplied evil text:

The additional indentation is because I cut the lines manually.

Some Chinese lorem ipsum:

SlySven

Somehow my review comments didn't get posted at the time...

From the screen-shots I can see you have got the status bar done in some way after all - and your "column" value is effectively a "grapheme" count (which I think is appropriate in the context in which we will be using it), so is "offset" equivalent to bytes into the file then?

I am a bit suspicious in that this "new" editor is, IMHO, not just something that can be dropped in but is itself quite a substantial piece of code - is it perhaps, a bit too much for our needs, I wonder? Are there any other project using it that we might see it in action as it were?

SlySven · 2017-05-05T17:01:03Z

.travis.yml

  - cd ../build
  - if [ "${TRAVIS_OS_NAME}" = "osx" ]; then export LDFLAGS=" -L/usr/local/opt/qt5/lib ${LDFLAGS}"; export CPPFLAGS=" -I/usr/local/opt/qt5/include ${CPPFLAGS}"; fi
-  - if [ "${Q_OR_C_MAKE}" = "qmake" ]; then qmake -v; qmake ../src/src.pro && make -j2; else cmake --version; cmake .. && make -j2 && make check; fi
+  - if [ "${Q_OR_C_MAKE}" = "qmake" ]; then qmake -v; qmake ../mudlet.pro && make -j2; else cmake --version; cmake .. && make -j2 && make check; fi


💭 I do like the idea of renaming the main qmake project file from src.pro to mudlet.pro given that we now have other files in sub-projects that are also called src.pro but changing the build structure so that the original ./src/src.pro is not the "top-level" project file may throw up odd effects - I believe that the communi library is now correctly configured as a sub-project of the original src.pro file and the yajl code has also been moved into a 3rdparty sub-directory position relative to the main application but these changes seem to position the edbee editor as an entity on the same level as the Mudlet application (even though it is also now positioned in a 3rdparty sub-driectory) which may throw up some oddities in getting both of the project build systems to work as intended. 😕

I'm not into this idea because it would mean everyone compiling Mudlet would stop being able to do so and be really confused until they figure out that we introduced a new, high-level makefile. Is this absolutely mandatory and can we make edbee work without causing a lot of pain to everybody?

Yes, we'll update the instructions, but everyone knows that nobody reads the instructions.

SlySven · 2017-05-05T17:04:06Z

3rdparty/edbee-lib/LICENSE

+
+* Redistributions of source code must retain the above copyright notice, this
+list of conditions and the following disclaimer.
+* Redistributions in binary form must reproduce the above copyright notice, this


This means, I think, that the "About Mudlet" dialog might need to include something about this...? Though IANYL !

vadi2 · 2017-05-06T03:40:38Z

is it perhaps, a bit too much for our needs

Definitely not - if you look at user feedback, nobody is saying is saying our current editor is too feature-rich. There is consistent feedback throughout the years that it is too basic. I mean, it can't even do highlighting right when the standard for an IDE these days is auto-completion of functions sorted in the order of usage across the world...

vadi2 · 2017-05-09T19:10:56Z

src/dlgSourceEditorArea.cpp

+    // QDir::homePath() + "/.config/mudlet/edbee/"
+
+    edbee::TextGrammarManager* grammarManager = ei->grammarManager();
+    edbee::TextGrammar* grammar = grammarManager->readGrammarFile( QDir::homePath() + "/.config/mudlet/edbee/Lua.tmLanguage" );


Put this into the mudlet_alpha.qrc please - see mudlet-mapper.xml for an example of how to load it once there :) that'll ensure the file is always in the application. It won't be overwritable by the users, but we should support custom themes more properly than swapping files around anyhow.

vadi2 · 2017-05-11T06:24:59Z

Jotting down what we discovered on Discord - the editing widget is corrupted and crashes if you try to select text on all but the latest opened profile.

…pened. I moved the initialisation code for the editor instance to mudlet.cpp so that it would only get executed once.

…evelopment

vadi2 · 2017-05-18T10:55:07Z

Yeah, works, nice!

What's next for this?

keneanung · 2017-05-18T13:32:40Z

As mentioned on discord, I finished the cmake build of the project and created the PR edbee/edbee-lib#10. So I need to wait a bit until it's accepted, then I'll add the sub-module and integrate edbee into our compilation for good.

I also have the feeling that we may be able to get rid of the second project file again.

vadi2 · 2017-05-19T13:01:08Z

Mudlet.tmTheme.zip

Here's my take on getting a theme that's closest to what we've got now. It has a few bugs but mostly things I can live with.

vadi2 · 2017-06-03T05:00:29Z

Search result highlighting is dodgy - when there are multiple results in the same script, it only seems to ever highlight one, if it even decides to highlight:

Unfortunatly they can't be platform-specific as they were before

It's incorrect right now as it doesn't actually track modified status.

vadi2 · 2017-06-03T08:49:55Z

I'm also having some sort of a rendering bug when multiline comments are involved:

We've got time, latest PRs can get in is by the 5th.

vadi2 · 2017-06-03T09:00:25Z

I've filed the rendering error with reproduction steps over at edbee/edbee-lib#23.

SlySven · 2017-06-03T15:11:27Z

src/dlgTriggerEditor.cpp

             SLOT(slot_updateStatusBar(QString))
         );
-    simplifyEdbeeStatusBarRegex = new QRegularExpression(R"(^(.+?) \|)");
+    simplifyEdbeeStatusBarRegex = new QRegularExpression(R"(^(?:\[\*\] )?(.+?) \|)");


👎 I think this will need/ought to be reverted as I suspect fixing the undo/redo history issue will also cure this - so it actually works as intended - i.e. [*] shows up only when the content has been changed from what was initially painted into the widget...

SlySven · 2017-06-03T15:12:43Z

src/edbee_defaults/Mudlet.tmTheme

-				<string>#D68B78</string>
+				<string>#000080</string>
+				<key>fontStyle</key>
+				<string> bold</string>


You have a leading space - is that significant as part of that XML entity?

It doesn't seem to be - bolding works.

The online editor spits it out that way and edbee doesn't see it as a problem, so I'm leaving it be.

Essential update to mudlet.cpp

clearDocument function - still bugged

vadi2 · 2017-06-05T12:24:47Z

We've decided to shift it over to the next milestone so we have more time to test edbee, iron out the existing issues, and add new features. I'd also like to merge this PR into development right after 3.2 is out since it is 90% ready and the PR is getting unwieldy to track issues in - merging it in will allow us to use the actual issues.

SlySven · 2017-06-07T16:06:08Z

In a recent commit the following change was made:

 {
@@ -574,7 +581,7 @@ void TextUndoStack::clearRedo(TextEditorController* controller)
         if( controllerIndexMap_.contains(controller) ) {
             idx = this->controllerIndexMap_.value(controller);
         } else {
-            Q_ASSERT(false);    // warning view isn't registered!
+            Q_ASSERT(false && "The current controller isn't registered with the undostack!");    // warning view isn't registered!
         }
 
         // remove all items from the stack AFTER the given index

💡 You may be interested to know that the Qt creators also include an extended: Q_ASSERT_X(...test...,"...fail message...") which might better fill the role that the above change makes...!

vadi2 · 2017-06-07T16:19:25Z

That's code inside the edbee library, Stephen! Not ours haha.

I know this PR has a few issues, but they are minor, and it is getting klunky to track them all. @SlySven per #985 (comment) would you mind if I merged this now and we ironed out the minor issues in the course of the month?

The undo bug has been fixed, by the way!

SlySven · 2017-06-07T20:56:18Z

OK, it would be nice if the modified indicator was present on the status bar but I can live without it. With all the changes the commit message for the "Squash and Merge" will be interesting to see...! 😀

* Removed duplicate clear event handlers call * Revert back to dev version. 3.3 here we go! * Adds saveWindowLayout() call to AutoSaveOnExit processing. * Edbee editor implementation (#985) * Added a frame to edbee so it looks nicer * Got utf8 module to load (#1074) (update packaging!) * Modified tooltip for Save and Save Profile to clearly indicate their keyboard shortcuts * Added: shortcut for delete action in editor (#1084) * shortcut added for delete action * Removed redundant edbee config related code (#1091) * Delete TScriptEditorManager.h * Delete TScriptEditorManager.cpp * BugFix: import some fixes by "Zolder" from Mudlet (Realms of Legends) fork import: some Zoilder fixes from the MudletRL fork: * in TBuffer::translateToPlainText(...): make some MXP related code execute only if Host::mFORCE_MXP_NEGOTIATION_OFF is NOT set as well as another condition. * in TBuffer::wrap(...): change a for(...) {...} loop termination condition be a "<" rather than a "<=" test - which sounds like an "off-by-one" error fix-up. * In TTextEdit:updateScreenView(): revise code that seems to prevent the width of a "main" console being set too small and NOT written to the "parent" Host::mScreenWidth variable - the original modification removed such a restriction completely, but I have just lowered the minimum from 100 to 40 and ensured it is always stored both in the local "main" console and to the parent record in the Host class for that console. * In TTextEdit::drawForeground(...): revise the behaviour *I think* when at the point where a console "split" becomes unnecessary... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Cut down on the length of some variable names (#1086) * Clarified use of QLatin1String * Adding GCC 5 for C++14 requirement (#1098) * Fixed "reset map colors" button to work (#1049) * Fixed "reset map colors" button to work That's a 5 year old bug out of the way! * Change travis configuration to use installed gcc-5 (#1108) * Change travis configuration to use installed gcc-5 * Fixes #1104 (#1109) Thanks to Rick for his prompt response on this * Fixed typo in GeyserLabel.lua Per #1112 * Fix locale to C Enforce uniform locale so scripts don't get tripped up on number representation differences (. vs ,) * IRC client update of UI and logic (#1072) * Add Communi Model & Util libs * Full refactor of IRC Client code & UI This retains the primary functions of the old IRC client but adds many more new IRC commands by default. The UI is slightly more organized and interactive now. * Adds QPointer to IRC Dialog pointer variable. * Update Lua `sendIrc()` slightly. * Added /msg command, Input History, and updated display colors. Input History stores a total of 8 previously entered commands the user can cycle through using the Up Arrow key. The previously include /msg command has been added again. Colors of some messages have been updated for (relatively) easier distinction of message lines. * Updated channel handling. * Fix CMake builds Things needed to fix CMake builds: - communi CMake builds needed `include_directories` explicitly specified - more MOC calls in communi - more explicit dependencies to MOC files in communi - ircmessageformatter must be compiled into mudlet * IRC3 with more Lua features (#1087) Changes IRC client to run with settings given per-profile, making the IRC client more visible and configurable within Lua. This adds configuration options to the settings window in the "Special Options" tab for configuring an IRC client on the host profile which opens the settings window. See the PR summary comment for details on available Lua functions and IRC Client commands. * Add a Code of Conduct (#1110) * Create CODE_OF_CONDUCT.md * Fix for the QMake warnings caused by the IRC library includes. * Finished formatting all filed & added braces (#1115) * Finished formatting all filed & added braces * Re-enabled map load on profile load (#1118) * Re-enabled map load on profile load - disabling it broke scripts that relied on map data w/o the map open * updated assignments. * Event-based gamepad functionality (#1106) * Add theme switching to code editor (#1095) * Fix more Toolbar & Button bugs (#1080) (#1090) * Fix bugs with Buttons & Toolbars. - Fixed change detection for location, orienation, and CSS data. - Buttons are not rendered unless they are part of a group, Toolbar/Menu. - ToolBars whos locations are changed now hide their previous TToolBar or TEasyButtonBar instance as needed. * Fix Buttons being left behind when parent toolbar is deleted. Also allows TAction to use QPointer<T> * Update old sourceforge page links (#1132) (#1134) * Fixed blank command separator to not separate as people expect * Replaced isTempKey, isTempAlias, etc with isTemporary (#1102) * also pushed isFolder() and setIsFolder() to the parent Tree class * Give meaning to encodings (#1107) * Delete dev_README Deleted outdated dev_README file. It also didn't seem to be used all that often, else people would have raised the fact that it's outdated... * Update travis to use Qt 5.9 for compiling (#1141) * Re-add single QT 5.6 build job Since we want to keep sure that the minimal Qt version is still compilable (currently we need at least 5.6), we add a single job for that version. * Refactor: rename QMake project/sub-project files (#1103) * refactor: rename QMake project/sub-project files It is down right confusing having several project files in the Qt IDE which are all labelled "src" - this commit renames the main project file from "src.pro" to "mudlet.pro" and also renames: * the lua_yajl module from src.pri to lua_yajl.pri * the luazip module from src.pri to luazip.pri it also: * adds a new communi.pri file (see below) I also took the liberty of renaming the project resource file from: * mudlet_alpha.qrc to mudlet.qrc (we are well past the alpha stage now!) and sorting a couple of items into the right order. By creating a local project file 3rdparty/communi/communi.pri it is possible to group the three separate but related communi libraries into one - as it happens the effective content of the new file is identical to that of the communi libraries own libcommuni/src/src.pri but it has some notes on how the portion of the upstream library that we are using was picked out of there; how to identify the effect version and how to (hopefully) recreate things if upstream gets revised in the future! By not using the upstream "src.pri"/"src.pro" files we avoid the confusion of having a generic "src" project in the Mudlet project as a whole and it is clearly identify-able as a file from the Mudlet project rather than the sub-project that it pulls into the whole thing... There is an minor nuisance side-effect in that having the main project src.pro file open in a Qt Creator IDE or stored in a session will get confused when this commit takes effect as the file will disappear from the repository - it will be necessary to close the project and open the new src/mudlet.pro project file (and possibly re-enter the build steps) - OTOH the main project will now be identified as "mudlet" in Creator rather than the previous "src". 😄 Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Removed accidental debug echo left in (#1151) * initialize int nIrcPort with dlgIRC::DefaultHostPort value. (#1153) * Removes false from sendIrc() return, ignores command filtering status (#1154) * Removes false from sendIrc() return, ignores command filtering status (not used). * Remove punctuation from lua messages * Improved layout of IRC preferences (#1152) * Fix get map events (#1120) * Adapt addMapEvent error messages to current standard * Fix getMapEvents() The function now returns a proper indexed table of objects that each describe a map event. * Add missing call to set Editor as editable. (#1159) * Fixed tab indent to be two spaces again * Fixed getComputerEncoding in case no key found It'll now return the original value passed - it's way better than returning the wrong value. * Add linux ci deployment (#1128) * Modify files needed for CI deployment of linux builds * Syntax fix in .travis.yml * tar the CI AppImages as well * Add lua sqlite runtime dependency * Unset LD variable for linuxdeployqt * Bugfix: unset LD_LIBRARY_PATH in every codepath * Test: install appmenu-qt5 for global menus * Revert 781ef97 (Install appmenu-qt5) The issue was that the first AppImage used Qt 5.6.2 instead of Qt 5.9 (which is how 3.2 was built and how it is build now after merging development in) * Remove manager again (#1163) * Improved map load output to be condensed down if it's all successful (#1117) OK! Would be happy to see that in as well for maps that take a while to load (>1s). * Re-enable search highlighting (#1096) * Remove mainwindow statusbar (#1162) * Replaced statustips with tooltips in the mapper menu * Removed statusbar * Tagging 3.3.0 * Initial QTextToSpeech additions * Further TTS additions and bugfixes * Wrapping TTS functions in #ifdefs for QT_TTS_LIB * Missing #ifdefs * More misplaced #ifdef lines for TTS functions * More QT_TTS_LIB ifs * Adding QTextToSpeech to cmake lists * Various TTS updates * Adding GetState to TLuaInterpreter.h * Minor fixes * Tts temporary fixes * Exchanging toLatin1 with toUtf8 * Fix cmake TTS module includesion * Install Qt 5.9 TTS module on linux * Use Qt provided definition for enabled modules We don't need (and possibly don't want) to provide our own definition for when a module is enabled. Let's use the Qt provided definition instead. * Output confirmation messages of enabled Qt modules * Use upper case "Gamepad" in output * ttsClearQueue crash fix * Fix for global speech events * Whitespace replacement * Various minor fixes * More minor fixes. * Cleanup: make CMakeList.txt have uniform indenting and adjust CMake message The minimum versions of the Qt TextToSpeech and Gamepad reported in the CMake project files needed tweaking. I have also tried to regularise the indentation in the Mudlet CMake project files to standardise on 2 spaces. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Reformat: clean up code-loyout of new TTS TLuaInterpreter code Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * BugFix: fixup a switch() in (int) TLuaInterpreter::ttsGetState(lua_State*) This switch was missing "break;" on all the cases and must have been defective without them - for all but the last case extra strings would have been pushed onto the lua stack but as the return value was 1 they may have been discarded... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Enable Qt 5.9 Windows builds for testing * Deploy Qt 5.9 builds for testing * Fixing double-events for queueing purposes * Added missing symbol * Added missing symbol * Updating tts events to globals and adding voice * Create TTSValues.lua * Adding TTSValues to LuaGlobal * Adding TTSValues to Mudlet project * Update CMakeLists.txt * Update TTSValues.lua * Update Qt to 5.10 for trusty This is needed to hopefully have some TTS backend plugins in Linux * Queueing and crash fixes * Renaming tts funcs * Renaming internal functions * Adding functions for retrieving settings * Fixing typo * Making ttsGetState public * Improve error messages for ttsGetCurrentLine() It can be incredibly frustrating to just get a boolean back as an error message when you don't know what is going on * Update error message to be consistent with the new style * Aligned error messages to be consistent with the new style * Fix ttsClearQueue to return nil+error, not actually error on invalid index * Minor code formatting * Floats to doubles * Update documentation links

Edbee editor implementation, take two

2619ad4

SlySven reviewed May 1, 2017

View reviewed changes

ahmedcharles reviewed May 1, 2017

View reviewed changes

ahmedcharles modified the milestone: 3.2 May 4, 2017

Tom Scheper added 5 commits May 5, 2017 15:44

Adding mudlet.pro to incorporate third party dependencies properly

2f91731

Inclusion of libedbee into 3rdparty, and updates to src.pro for edbee…

f8285ba

…-includes

Changed compile instructions for travis from ../src/src.pro to ../mud…

de19e65

…let.pro

Changed QsLog to qslog

c623df3

Removed redundant QDebug.h inclusion

fca4f40

Fixing Qt 5.8 ambiguity error due to QStringRef.compare now having mo…

f3d4dd1

…re overloads than 5.6

SlySven reviewed May 5, 2017

View reviewed changes

Make src/src.pro the main project file again

a4c6c55

vadi2 reviewed May 9, 2017

View reviewed changes

keneanung added 4 commits May 9, 2017 21:19

Make travis use the reinstated src.pro file again

caf6fde

Merge branch 'development' of github.com:Mudlet/Mudlet into development

fc00d1d

Add gpl header to new src.pro

c22159c

Add compiler warnings to ignore certain edbee warnings

fc33e4b

tomcss added 2 commits May 17, 2017 19:45

Fixes for the crash that occurs when multiple profiles have editors o…

917544f

…pened. I moved the initialisation code for the editor instance to mudlet.cpp so that it would only get executed once.

Merge branch 'development' of https://github.com/tomcss/Mudlet into d…

1f562be

…evelopment

vadi2 added 4 commits June 3, 2017 07:42

Fixed the default start page in profile preferences

b4a7761

Fixed keyword highlighting to be same as before

46bebd2

Improved selection colours

08052cc

Unfortunatly they can't be platform-specific as they were before

Removed [*] from showing

951c351

It's incorrect right now as it doesn't actually track modified status.

SlySven reviewed Jun 3, 2017

View reviewed changes

tomcss and others added 4 commits June 4, 2017 10:48

978773d

Essential update to mudlet.cpp

cc013a9

clearDocument function - still bugged

Merge remote-tracking branch 'origin/development' into development

9cf2f99

Merge branch 'development' into development

eb74dcf

vadi2 modified the milestones: 3.3, 3.2 Jun 5, 2017

vadi2 added 2 commits June 6, 2017 17:17

Updated edbee to fix refresh error

954ae57

Updated edbee - fixed crash on undo

df3ff79

vadi2 and others added 3 commits June 7, 2017 18:22

Merge branch 'development' into development

2b6706c

Switch to multidocument system

594d6ad

Merge branch 'HEAD' of https://github.com/tomcss/Mudlet into development

d680a84

SlySven approved these changes Jun 7, 2017

View reviewed changes

vadi2 merged commit 95b8bf5 into Mudlet:development Jun 8, 2017

This was referenced Jun 8, 2017

QMake project file is missing some files added to support new edbee editor #1077

Closed

New C++ support files for edbee editor are missing Copyright Headers #1078

Closed

vadi2 pushed a commit that referenced this pull request Jul 2, 2017

Edbee editor implementation (#985)

1f321c6

Uh oh!

Conversation

tomcss commented May 1, 2017

Uh oh!

SlySven left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SlySven commented May 2, 2017

Uh oh!

SlySven commented May 5, 2017

Uh oh!

keneanung commented May 5, 2017

Uh oh!

vadi2 commented May 5, 2017 via email

Uh oh!

tomcss commented May 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SlySven left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vadi2 commented May 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vadi2 commented May 11, 2017

Uh oh!

vadi2 commented May 18, 2017

Uh oh!

keneanung commented May 18, 2017

Uh oh!

vadi2 commented May 19, 2017

Uh oh!

vadi2 commented Jun 3, 2017

Uh oh!

vadi2 commented Jun 3, 2017

Uh oh!

vadi2 commented Jun 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vadi2 commented Jun 5, 2017

Uh oh!

SlySven commented Jun 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vadi2 commented Jun 7, 2017

Uh oh!

SlySven commented Jun 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

SlySven left a comment •

edited

Loading

tomcss commented May 5, 2017 •

edited

Loading

SlySven commented Jun 7, 2017 •

edited

Loading