Infrastructure: run Lua tests on macOS#6820
Merged
vadi2 merged 9 commits intodevelopmentfrom Jan 1, 2024
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Split the test setup steps for Linux and macOS into separate steps to handle platform specific differences. On Linux, copy the built binary to the workspace. On macOS, copy the .app bundle to Desktop, remove codesigning, and run tests from the bundled binary. This allows the workflow to handle test setup properly on each platform.
Member
Author
|
Got it to work 🥳
|
demonnic
approved these changes
Jan 1, 2024
Member
demonnic
left a comment
There was a problem hiding this comment.
lgtm, kind of surprised it takes twice as long, but that could just be the setup time.
vadi2
added a commit
to vadi2/Mudlet
that referenced
this pull request
Jan 5, 2024
<!-- Keep the title short & concise so anyone non-technical can
understand it,
the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Run Lua tests on macOS, so we can catch any LuaGlobal loading issues.
#### Motivation for adding to Mudlet
Close Mudlet#6687
#### Other info (issues closed, discussion etc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Run Lua tests on macOS, so we can catch any LuaGlobal loading issues.
Motivation for adding to Mudlet
Close #6687
Other info (issues closed, discussion etc)