Add: allow transparent text labels through right click map menu#5873
Merged
Delwing merged 1 commit intoMudlet:developmentfrom Jan 21, 2022
Merged
Add: allow transparent text labels through right click map menu#5873Delwing merged 1 commit intoMudlet:developmentfrom
Delwing merged 1 commit intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vadi2
reviewed
Jan 17, 2022
Member
vadi2
left a comment
There was a problem hiding this comment.
I tested it with https://clipground.com/images/clear-seas-clipart-3.jpg which has a transparent background, but it's still not coming out right -
Does it work for you?
Contributor
Author
|
This is fix so text label can use fg and bg color with alpha. Didn't touch images here. |
vadi2
approved these changes
Jan 17, 2022
Member
|
Werks |
vadi2
pushed a commit
that referenced
this pull request
Jan 31, 2022
…in JSON map files (#5929) This error was introduced in the original "load/save Maps as JSON" PR, #4546 ...! Also include a check for transparency - as a recent PR #5873 (*Edited: not 5783!*) added the option for that to both the fore and background colours of map labels. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> #### Release post highlight Fix - prevent a corner case not saving the fore/background colour details for map labels correctly in JSON map files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
There was no way to create text label with transparent background through right click menu in map.
Motivation for adding to Mudlet
Getting label creation more consistent with Lua API.
Other info (issues closed, discussion etc)
This is first PR to address some issues with labels. I have some plans to improve that particular area. Hopefully I find some time and energy to do it :)
Release post highlight