Fix: correctly save fore/background color and transparency of labels in JSON map files#5929
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom Jan 31, 2022
Conversation
This error was introduced in the original "load/save Maps as JSON" PR, Mudlet#4546 ...! Also include a check for transparency - as a recent PR Mudlet#5783 added the option for that to both the fore and background colours of map labels. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Member
Author
|
@vadi2 it isn't obvious whether it has been an issue - as the original PR is about 10 months old and I don't think anyone has moaned about it. The recent addition of transparency to the label colours means that a change was required anyhow... |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
|
Thanks, good find. I won't be able to test this, can anyone else pick it up? |
Member
|
Merging so it makes it into the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error was introduced in the original "load/save Maps as JSON" PR, #4546 ...!
Also include a check for transparency - as a recent PR #5873 (Edited: not 5783!) added the option for that to both the fore and background colours of map labels.
Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
Fix - prevent a corner case not saving the fore/background colour details for map labels correctly in JSON map files.