Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

• linux: https://make.mudlet.org/snapshots/57c984/Mudlet-4.10.1-testing-pr4418-4b174f2c-linux-x64.AppImage.tar
• osx: https://make.mudlet.org/snapshots/a9d66f/Mudlet-4.10.1-testing-pr4418-4b174f2c.dmg
• windows: https://make.mudlet.org/snapshots/08cd8e/Mudlet-4.10.1-testing-pr4418-8e4a61d9-windows.zip

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

Not a solution that immediately came to my mind, but it works, so why not 😃

Not sure how much I like the mudlet.Locale.packageInstallSuccess.message structure, yet. Maybe refactor later.

Looks like the function isnt available yet, \Other.lua:9: attempt to call global 'loadTranslations' (a nil value))?

Sorry to bother you with this already, I have marked as draft again!

This is probably not the best way to solve this, when we get more Lua translations..!

So it seems, the C function returns true or false, but these will never reach Lua.
Therefore, the simple if/else I built will always receive nil and report failure.

As the C function is doing multi duty, I don't even want to untangle and enhance it.
That was probably the direction you expected this solution to take way up above?
However I am not sure which other use cases I would destroy with modifications.

Workaround suggested courtesy of demonnic:

could add a one-time listener for the sysPackageInstall event with a tempTimer to remove it and display the failure message if it hasn't fired by X seconds

edit: wrong button, please ignore

Also add .trigger as acceptable package suffix

Testing the Github codespases approach..

I've updated installPackage() to return true/false so you have an easier time with this.

Not sure why, but now I can "install" an empty .xml file, and it will be shown in package manager (and return true)
Whereas in PTB, dropping the same file in Mudlet will not produce any entries in package manager.
@vadi2 any changes you did maybe!?

Meanwhile..

#4418 (comment) not that I know of.

#4418 (comment) Looks good. Maybe a bit more exciting? Feels a bit too robotic.

#4418 (comment) Looks good. Maybe a bit more exciting? Feels a bit too robotic.

Are you referring to the text contents? Yeah, I was just glad this actually arrived and had the correct colors, etc.
On the other hand, my orientation were the robotic texts shown on Mudlet startup, so this follows the same style.
Feel free to suggest other texts though...

#4418 (comment) not that I know of.

Me neither.. but how to remedy?
I could very well burn this branch and redo it all over again, just to make sure.
Not sure if there is another way that could be completed with less work maybe?

Actually localization doesn't work, yet, as that mudlet-lua.json isn't multi-level capable, or I didn't find how.

Sorry, this fell off my radar. I've repaired the branch so the diff looks okay (just by merging in the latest).

Open issues here:

• make localisation work again
• change success message to ok and color accordingly

Not sure why, but now I can "install" an empty .xml file, and it will be shown in package manager (and return true)
Whereas in PTB, dropping the same file in Mudlet will not produce any entries in package manager.

• Need to test this again, not to introduce any regressions

Not sure why, but now I can "install" an empty .xml file, and it will be shown in package manager (and return true)
Whereas in PTB, dropping the same file in Mudlet will not produce any entries in package manager.

• Need to test this again, not to introduce any regressions

This is actually already so in 4.10.1 release version so no regression introduced here.

For some reason, the most recent commits are not (yet?) shown in this PR, only listed in the commits of the branch..!? How do I update PR? edit: seems like Github was struggling.