Skip to content

Fix localization for notify on drag drop packages#4655

Merged
Kebap merged 3 commits intoMudlet:Notify-on-drag-drop-packagesfrom
Edru2:Notify-on-drag-drop-packages
Jan 19, 2021
Merged

Fix localization for notify on drag drop packages#4655
Kebap merged 3 commits intoMudlet:Notify-on-drag-drop-packagesfrom
Edru2:Notify-on-drag-drop-packages

Conversation

@Edru2
Copy link
Copy Markdown
Member

@Edru2 Edru2 commented Jan 18, 2021

Brief overview of PR changes/additions

loadTranslations only accepts one level arrays in the json file. (for now)

Motivation for adding to Mudlet

Other info (issues closed, discussion etc)

@Edru2 Edru2 requested a review from a team January 18, 2021 20:31
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Jan 18, 2021

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

Copy link
Copy Markdown
Contributor

@Kebap Kebap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍

@Kebap Kebap merged commit 02d9bcd into Mudlet:Notify-on-drag-drop-packages Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants