Make searching variables optional (defaults to off)#3543
Make searching variables optional (defaults to off)#3543vadi2 merged 6 commits intoMudlet:developmentfrom
Conversation
…abled by default now. This option is in the search menu on the left side of the search bar, positioned with the Case Sensitivity option.
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
Please note, this PR does Edited 2020/03/29 by @SlySven: as now done. |
|
I'll see if I can run something up tonight - and I will get to play/review this code as well - so we can still get this one out the door in the next couple of days. |
…ions Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Could you merge latest |
Revise: add "with-variables" icons & persistent storage of search options Not entirely on-board with the decision to put the settings in the profile, instead of in the QSetting that hold all the other dlgTriggerEditor state information(position, size, splitter placements), but it's not really a big deal either way. Thanks for the icons and code!
SlySven
left a comment
There was a problem hiding this comment.
Since I contributed a chunk of code to this composite PR I ought to rule myself out of being the one to give approval. I can say, however, that it (now) does what it says on the tin, and the Search Options UI has been properly extended to support it.
👍
|
Thanks a lot for this. It's pretty awesome 🙌 🙌 |
* Adds an option for variables to be included in searches, which is disabled by default now. This option is in the search menu on the left side of the search bar, positioned with the Case Sensitivity option. * Revise: add "with-variables" icons & persistent storage of search options Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Update copyright stamp Mudlet#1 * Update copyright date Mudlet#2 * Trim tooltip to UX standard Co-authored-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Vadim Peretokin <vperetokin@gmail.com>
Brief overview of PR changes/additions
Adds an option for variables to be included in searches, which is disabled by default now. This option is in the search menu on the left side of the search bar, positioned with the Case Sensitivity option.
Motivation for adding to Mudlet
Over the course of many years using Mudlet, I'm not sure that I have searched variables intentionally more than a single time. However, due to the large amounts of data I keep saved in various tables in Lua, searching through the variables causes Mudlet to lag for several seconds any time I want to search.
Other info (issues closed, discussion etc)
Supersedes #3415, which added a toggle to the profile settings. The search options menu is a more appropriate place for it. Even if the menu is non imminently discoverable, the default of NOT including variables seems to be agreed upon as the correct default. See previous discussion on that PR.