Add option to disable search including variables.#3415
Add option to disable search including variables.#3415dicene wants to merge 1 commit intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
I agree with the default to off - but could it be more context-sensitive and go into the search options we already have? It'll be easier to find and change there. |
I wasn't aware that we HAD any search options already. I don't see them in Profile Preferences. I was a little unsure about whether Editor was the right place for it, but I was initially just thinking of it as options for Edbee, but IMO the tab is broader than that, including anything in the entire Script Editor itself. |
|
Actually, I think I've found you what you mean. Although, I think it's a bad sign as far as visibility goes if there are options that even someone that uses the program extensively(and contributes to it) wasn't aware of it in the first place... I suppose we COULD put it there instead, but I'm inclined to think that the number of people aware of the Case Sensitivity option in the first place is probably very low. I don't think that icon does a good job communicating that there are options to set. A "..." or gear icon would be more informative, I think. Additionally, the Case Sensitivity option is NOT saved between sessions, and I think that this particular option is appropriate for saving in the profile. |
|
It should be saved between sessions for sure, it'd be quite annoying if it didn't. As for the icon - I don't mind changing it to something more intuitive. Ask around to see if nobody else knew what it did? |
|
I knew, but should not be the yardstick by which this is measured, as I know about a lot of things that other people are surprised to hear. |
|
@dicene Did you want to finish this up? It's a popular request - otherwise I'm happy to complete it |
|
Requested changes made in another branch, this is now superceded by #3543. |








Brief overview of PR changes/additions
Adds a toggle in the Editor tab of Preferences that controls whether or not variables are included in the search functionality in the Editor.
Motivation for adding to Mudlet
Over the course of many years using Mudlet, I'm not sure that I have searched variables intentionally more than a single time. However, due to the large amounts of data I keep saved in various tables in Lua, searching through the variables causes Mudlet to lag for several seconds any time I want to search.
Other info (issues closed, discussion etc)
I'm inclined to think searching variables should be disabled by default, seeing as it has almost never been useful for me, and I've seen/heard other people mention that it was unnecessary for them, and just served to inflate search times and disincentivizes using it.
That said, I'm not certain that all the primary devs of Mudlet will agree with me on that, so I've set it to default to ON.