Fix for MacOS flickering caused by QOpenGLWidget#3387
Merged
vadi2 merged 2 commits intoMudlet:developmentfrom Mar 8, 2020
Merged
Fix for MacOS flickering caused by QOpenGLWidget#3387vadi2 merged 2 commits intoMudlet:developmentfrom
vadi2 merged 2 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Contributor
vadi2
reviewed
Mar 8, 2020
Member
vadi2
left a comment
There was a problem hiding this comment.
I've tested it and the last few lines of output are missing for me - are none of you guys getting this?
Video: https://streamable.com/rmyrn
Member
|
Could both of you review #3388 as well and compare? |
vadi2
approved these changes
Mar 8, 2020
vadi2
added a commit
that referenced
this pull request
Mar 8, 2020
* possible fix for MacOS flickering cause by QOpenGLWidget * Update src/Host.cpp Co-authored-by: Vadim Peretokin <vperetokin@gmail.com> (cherry picked from commit 897dcfd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
This small change updates the Console if a command is sent to the Mud (only for macos)
to prevent the flickering caused by QOpenGLWidget
Motivation for adding to Mudlet
flickering in macos caused by QOpenGlWidget
Other info (issues closed, discussion etc)
Please someone with mac os test it.
I could only test it in virtualbox but it seems to fix the issue.