Try another solution to flickering on macOS#3388
Closed
vadi2 wants to merge 1 commit intorelease-4.6from
Closed
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
This solution seems to work too, but it still has the strange text clipping as the other one does: https://streamable.com/ay390 |
Member
|
I cannot reproduce the text clipping issue. The only issue with this PR (compared to #3387) what I see is that sending an empty command (just pressing enter) still causes flickering. |
Member
Author
|
Yep, good find. Let's go with your solution then! Was good to try out an alternative and compare - I think this version would have caused less of the screen to redraw if it worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Try another solution to flickering on macOS
Motivation for adding to Mudlet
In an effort to find a good solution quicker, try an alternative to #3387
Other info (issues closed, discussion etc)
See https://forum.qt.io/topic/84262/mac-os-repainting-parented-widget-performance-seem-to-depend-on-ancestors-chain/5