Code match (release 30)bugfix faulty non error message alignment#278
Merged
SlySven merged 2 commits intoMudlet:developmentfrom Nov 11, 2015
Conversation
The PR for the release_30 branch, as well as catching up on a commit that failed to make it into that branch before also added a wrapper around cTelnet.postMessage() from the Host class. This commit adds that wrapper to the development branch. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Member
Author
|
I would like to merge this ASAP - it is also included in a following PR #280 so if any modifications are made they will also have to go into that... 🙏 |
Member
Author
|
⏳ I intend to merge this, unless there are any objections, - in 24 hours... |
|
+1 |
SlySven
added a commit
that referenced
this pull request
Nov 11, 2015
…ltyNonErrorMessageAlignment Code match (release 30)bugfix faulty non error message alignment
mehulmathur16
pushed a commit
to mehulmathur16/Mudlet
that referenced
this pull request
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh, this should have been a single commit but I forgot to squash them together * sigh *.
Read the message for the second commit for details but the bottom line is that it add a Host::postMessage(const QString) wrapper for cTelnet::postMessage(QString) so the latter class doesn't have to be #include d or referred to directly by the using class.
This is to make the two code branches have the same code in the areas touched after #277 is Pulled...