(release_30)BugFix: faulty message alignment, cTelnet::postMessage() in non-ERROR…#277
Merged
SlySven merged 1 commit intoMudlet:release_30from Nov 11, 2015
Conversation
… cases
A version of this commit never got into the release_30 branch with the
effect that all the postMessage() type calls with messages OTHER than the
ones beginning with "[ ERROR ]" were not being aligned correctly.
Original commit-e17d023b read:
===========================================================================
Code that was put in to fix messages with tag "[ ERROR ] - " was not copied
to the other tag types, so those messages were not lined up correctly as
per:
"[<tag>] - <message line 1 ...>
<message line 2 ...>
...
<message line n ...>"
===========================================================================
Whilst fixing this I decided to give the Host class a wrapper around
mTelnet.postMessage() so that other classes could access this without
having to include the cTelnet header or access it via a Host pointer.
As a result other existing uses have been modified where it is advantagous
to do so.
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Member
Author
|
I would like to merge this ASAP - it is also included in a following PR #279 so if any modifications are made they will also have to go into that, the fix that forms the main part of the commit has already been incorporated into the development branch for some time... |
Member
Author
|
⏳ I intend to merge this, unless there are any objections, - in 24 hours... |
|
+1 |
SlySven
added a commit
that referenced
this pull request
Nov 11, 2015
…rMessageAlignment (release_30)BugFix: faulty message alignment, cTelnet::postMessage() in non-ERROR…
mehulmathur16
pushed a commit
to mehulmathur16/Mudlet
that referenced
this pull request
Feb 16, 2024
* correct some issues found by clang-analyzer (dead stores, one of them a bug in the page allocator) * fix other warnings on clang * turn of warnings-as-errors on CI for clang and msvc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… cases
A version of this commit never got into the release_30 branch with the
effect that all the postMessage() type calls with messages OTHER than the
ones beginning with "[ ERROR ]" were not being aligned correctly.
Original commit e17d023 read:
Code that was put in to fix messages with tag "[ ERROR ] - " was not copied
to the other tag types, so those messages were not lined up correctly as
per:
===========================================================================
Whilst fixing this I decided to give the Host class a wrapper around
mTelnet.postMessage() so that other classes could access this without
having to include the cTelnet header or access it via a Host pointer.
As a result other existing uses have been modified where it is advantagous
to do so.
Signed-off-by: Stephen Lyons slysven@virginmedia.com