Revise 2D Mapper class to allow better translation by SlySven · Pull Request #1810 · Mudlet/Mudlet

SlySven · 2018-07-13T17:42:10Z

This was prompted by items 6, 7 and 8 of #1802 .

It add the third (integer quantity inserted into translation at %n position) argument needed for effective translations of quantifiable numbers of a noun in a sentence for one translation and explains the multiple replaceable parameters for all of the touched translations. As the one with %n will always be for two or more arguments there is technically no need for the single or none quantity translations if they fall outside of the different plural forms in a particular language...

Signed-off-by: Stephen Lyons slysven@virginmedia.com

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

Further improvements to the class file which picks out some more texts for translation and improves disambiguation/translation comments. Some more are also better identified for plural handling. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

Kebap

Few remarks

Kebap · 2018-07-14T09:59:16Z

src/T2DMap.cpp

+                                         .arg(tr("<p>Click on a line to select or deselect that room number (with the given name if the "
+                                                 "rooms are named) to add or remove the room from the selection.  Click on the "
+                                                 "relevant header to sort by that method.  Note that the name column willl only "
+                                                 "show if at least one of the rooms has a name.</p>")));


Can you outsource the surrounding p tag as well?

I deliberately make an exception for paragraph tags because if there is more than one it is better to not hide just the first opening and last closing ones - on the basis that it causes less surprise then if there is a </p><p> in the middle of a string.

Fair enough, but there are no such in the middle here?
I want to outsource these html marks as many and as often as possible.
Agreed on avoiding the surprising paragraph tags. In those cases where they are in the middle, they should stay on the edges as well. But in this case, no tags are needed for translation at all, at all.

src/T2DMap.cpp

vadi2 · 2018-09-16T18:14:41Z

@SlySven ping, would you be able to finish this up?

Kebap · 2019-01-24T10:03:13Z

Changing "Work in progress" to "Backlog", as this hasn't been updated in a few months already.

…nternationalised Conflicts resolved in: - src/T2DMap.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

The buttons on the form that the user uses to select a normal exit direction to draw a new custom exit line for have texts that will need to be translated but the code was examining the literal text used which would break as soon as it was changed for another language. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

Change some `QString`s to use `QLatin1String`s constructor where it helps (place where it is use can accept them directly; no parameter replacements are needed, where same QString is used multiple times in the same file and compiler will arrange for the literals to be merged). Revised the text of a couple of translator comments. Comment out an unused line preceding some other commented out code. Changed capitalisation on "create room" menu item to match all others in the same compilation unit. Removed terminal punctuation on "create Label" context menu item tool tip to match all others in the same compilation unit. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

…merge Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

src/T2DMap.cpp

SlySven

Some things to do there then.

src/T2DMap.cpp

With the introduction of translations AND also after the conversion of the internal exit direction keys for normal exits in the `TRoom` data structures for custom exit lines, in: Mudlet#2106 (which was included in Mudlet 3.16.0) it has not possible to create new custom exit lines without encountering a bug that means the lines are drawn in black and do not show up whilst drawing, the properties dialogue also has no idea of the destination room and there are other oddities. This commit contains an extract from: Mudlet#1810 that was pending and had the fix for this problem Note that this does not fix the lua getCustomLines(...) function which, since 3.16.0 has also been using lower case keys to return the normal exit direction custom exit line details. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

vadi2

My point about using { and } for human-readable text in UI's still stands - I don't see other major software using it... it's not really idiomatic design and not very aesthetic. Maybe you have examples of others using it @SlySven?

src/T2DMap.cpp

Also adopted the optimum(?) `QString` initialisation process! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

vadi2

Pretty close - lets get it over and done with...

src/T2DMap.cpp

vadi2 · 2019-02-05T18:40:23Z

With the very important #2317 now in, let's get this merged so we can do a bugfix.

Also take out a double negative that is not that helpful in a tooltip and convert a menu item from the plural to the singular case as it can only do one item (custom exit line) per invocation. This also introduces some non-breaking spaces and hyphens so that fragments of the info texts are kept together should the display area be too narrow to fit each line as a whole. Due to at least one Qt bug it is not possible to put non-breaking spaces within the source file directly and have to be introduced in a different way - I have done it here by using the first reparable parameter (%1). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

vadi2 · 2019-02-06T05:57:58Z

src/T2DMap.cpp

-                                   .arg(_paid_name,
+                infoText = tr("Area:%1%2 ID:%1%3 x:%1%4%1<‑>%1%5 y:%1%6%1<‑>%1%7 z:%1%8%1<‑>%1%9\n",
+                              // Intentional separator
+                              "This text uses non-breaking spaces (as '%1's, as Qt Creator cannot handle"


What is this problem? lupdate has been fixed to handle C++11 string literals (finally, after 8 years...)

https://bugreports.qt.io/browse/QTCREATORBUG-17875 converted into https://bugreports.qt.io/browse/QTBUG-56538 and then closed as a duplicate. - However the fix in the latter is not applicable/relevant for the former (I think) but no-one seems to have picked up on it - I only found this bug recently when I wanted to include some non-breaking spaces here...

Now reported by me as: https://bugreports.qt.io/browse/QTCREATORBUG-22052 ! 😀

Enhance: revise 2D Mapper information text to allow better translations

1fdd465

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

SlySven added the 1 - Ready for review label Jul 13, 2018

SlySven assigned Kebap Jul 13, 2018

SlySven requested a review from a team July 13, 2018 17:42

SlySven requested a review from a team as a code owner July 13, 2018 17:42

SlySven changed the title ~~Enhance: revise 2D Mapper information text to allow better translations~~ Enhance: revise 2D Mapper class to allow better translation Jul 13, 2018

Kebap reviewed Jul 14, 2018

View reviewed changes

Kebap removed their assignment Jul 23, 2018

Kebap added 2 - Working and removed 1 - Ready for review labels Aug 12, 2018

vadi2 assigned SlySven Aug 19, 2018

Kebap added the enhancement label Sep 10, 2018

Kebap changed the title ~~Enhance: revise 2D Mapper class to allow better translation~~ WIP. Revise 2D Mapper class to allow better translation Sep 10, 2018

Kebap changed the title ~~WIP. Revise 2D Mapper class to allow better translation~~ Revise 2D Mapper class to allow better translation Oct 29, 2018

Kebap added 0 - Backlog and removed 0 - Work in progress labels Jan 24, 2019

SlySven added 2 commits January 24, 2019 17:52

Merge branch 'development' into Enhance_allow2DMapperInfoDisplayToBeI…

7211d67

…nternationalised Conflicts resolved in: - src/T2DMap.cpp Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

SlySven added the 0 - Work in progress label Jan 24, 2019

SlySven added 2 commits January 24, 2019 21:12

Revise: more polishing + remove a big chunk of dead code put back in …

1ec906e

…merge Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

SlySven assigned vadi2 and Kebap and unassigned SlySven Jan 24, 2019

SlySven requested a review from a team January 24, 2019 21:58

SlySven added 1 - Ready for review and removed 0 - Work in progress labels Jan 24, 2019

SlySven requested review from a team and removed request for a team January 24, 2019 21:58

vadi2 reviewed Jan 25, 2019

View reviewed changes

src/T2DMap.cpp Outdated Show resolved Hide resolved

src/T2DMap.cpp Outdated Show resolved Hide resolved

src/T2DMap.cpp Outdated Show resolved Hide resolved

src/T2DMap.cpp Outdated Show resolved Hide resolved

src/T2DMap.cpp Outdated Show resolved Hide resolved

SlySven commented Jan 25, 2019

View reviewed changes

Kebap removed the 0 - Backlog label Jan 26, 2019

SlySven mentioned this pull request Feb 2, 2019

Enhance: Increase resolution of yet more icons #2281

Merged

SlySven commented Feb 2, 2019

View reviewed changes

src/T2DMap.cpp Outdated Show resolved Hide resolved

SlySven mentioned this pull request Feb 2, 2019

(release-3.17) BugFix: 2D mapper custom line creation #2285

Closed

vadi2 reviewed Feb 3, 2019

View reviewed changes

src/T2DMap.cpp Outdated Show resolved Hide resolved

vadi2 removed their assignment Feb 3, 2019

Revise: following further peer review

be2a459

Also adopted the optimum(?) `QString` initialisation process! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

vadi2 reviewed Feb 5, 2019

View reviewed changes

src/T2DMap.cpp Outdated Show resolved Hide resolved

vadi2 reviewed Feb 6, 2019

View reviewed changes

vadi2 approved these changes Feb 6, 2019

View reviewed changes

vadi2 merged commit 1eca7cb into Mudlet:development Feb 6, 2019

SlySven deleted the Enhance_allow2DMapperInfoDisplayToBeInternationalised branch March 18, 2019 19:17

SlySven restored the Enhance_allow2DMapperInfoDisplayToBeInternationalised branch June 22, 2020 18:06

SlySven deleted the Enhance_allow2DMapperInfoDisplayToBeInternationalised branch June 22, 2020 18:20

Uh oh!

Conversation

SlySven commented Jul 13, 2018

Uh oh!

Kebap left a comment

Choose a reason for hiding this comment

Uh oh!

Kebap Jul 14, 2018

Choose a reason for hiding this comment

Uh oh!

SlySven Jul 14, 2018

Choose a reason for hiding this comment

Uh oh!

Kebap Jul 14, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vadi2 commented Sep 16, 2018

Uh oh!

Kebap commented Jan 24, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SlySven left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vadi2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vadi2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vadi2 commented Feb 5, 2019

Uh oh!

vadi2 Feb 6, 2019

Choose a reason for hiding this comment

Uh oh!

SlySven Feb 26, 2019

Choose a reason for hiding this comment

Uh oh!

SlySven Feb 26, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants