Fix getColumnNumber("main")#2317
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom Feb 5, 2019
druuimai:getColumnNumberFix#2316
Merged
Fix getColumnNumber("main")#2317vadi2 merged 1 commit intoMudlet:developmentfrom druuimai:getColumnNumberFix#2316
vadi2 merged 1 commit intoMudlet:developmentfrom
druuimai:getColumnNumberFix#2316
Conversation
…by calling to getColumnNumber(win).
|
Hey there! Thanks for helping Mudlet improve. 🌟 You can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
approved these changes
Feb 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…by calling to getColumnNumber(win).
Brief overview of PR changes/additions
This ensures that calling to GetColumnNumber(windowName) on the mudlet side will properly return the result for Xecho function on the Lua side.
Motivation for adding to Mudlet
I find it curious that moveCursor is not the main cause of misalignment rather, it is getColumnNumber that failed to return the result. so in this fix, it should now correctly return the result as intended.
Other info (issues closed, discussion etc)
this should resolve #2316 and #743