Add File & Directory skipping#61
Merged
Holt59 merged 12 commits intoModOrganizer2:masterfrom Jun 8, 2024
Merged
Conversation
# Motivations # Modifications - - Update BOOST_PATH for the correct boost version - Add .clang-format
Author
|
I'm still piecing together a PR for mod organizer that utilizes the newly added exposed functions, so this will stay as a draft in the meantime |
Author
|
Now ready for review |
Twinki14
added a commit
to Twinki14/modorganizer
that referenced
this pull request
May 27, 2024
# Motivations ModOrganizer2/usvfs#61 Highlights some reasons why the ability to skip files & directories would be beneficial # Modifications - Add two new settings, `skip_file_suffixes` and `skip_directories` - Wire the two new settings up to usvfs - Add two new buttons to the `Workarounds` dialog, one to adjust Skip File Suffixes and another for Skip Directories, both buttons act nearly identical to the Executable Blacklist button - Add a new grouping in the `Workarounds` dialog box that contains the usvfs buttons to keep the dialog a tad organized # Results
Holt59
requested changes
May 27, 2024
Author
|
Updated, all requested changes have been addressed |
Al12rs
reviewed
May 28, 2024
Al12rs
reviewed
May 28, 2024
Al12rs
requested changes
May 28, 2024
Al12rs
requested changes
May 28, 2024
Author
|
PR is ready for review again I've removed |
Al12rs
requested changes
Jun 2, 2024
Member
Al12rs
left a comment
There was a problem hiding this comment.
Seems good, I reviewed from phone though.
Have you been able to test and verify things are being skipped correctly?
Al12rs
approved these changes
Jun 4, 2024
Holt59
reviewed
Jun 6, 2024
Holt59
pushed a commit
to ModOrganizer2/modorganizer
that referenced
this pull request
Jun 15, 2024
* Use new Skip File & Skip Directory in usvfs. # Motivations ModOrganizer2/usvfs#61 Highlights some reasons why the ability to skip files & directories would be beneficial # Modifications - Add two new settings, `skip_file_suffixes` and `skip_directories` - Wire the two new settings up to usvfs - Add two new buttons to the `Workarounds` dialog, one to adjust Skip File Suffixes and another for Skip Directories, both buttons act nearly identical to the Executable Blacklist button - Add a new grouping in the `Workarounds` dialog box that contains the usvfs buttons to keep the dialog a tad organized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
Sometimes there's files or directories that could be skipped during linking to overall speed up the process or give us an overall cleaner result. Recently such circumstances have included files suffixed with
.mohiddenor directories named.git#60 is an example of an attempt at solving a specific example, but having such hardcoded values goes against what usvfs is
So a better solution is ideal
Modifications
skipFileSuffixandskipDirectories.skipFileSuffixare suffixes that are compared to the filename during file linking, and if the ending of the filename matches one of the intended to-skip file suffixes, the file will be skippedskipDirectoryacts similarly, but instead of a suffix the entire directory name is tested and compared