Use new Skip File & Skip Directory in usvfs#2033
Merged
Holt59 merged 9 commits intoModOrganizer2:masterfrom Jun 15, 2024
Merged
Use new Skip File & Skip Directory in usvfs#2033Holt59 merged 9 commits intoModOrganizer2:masterfrom
Holt59 merged 9 commits intoModOrganizer2:masterfrom
Conversation
# Motivations ModOrganizer2/usvfs#61 Highlights some reasons why the ability to skip files & directories would be beneficial # Modifications - Add two new settings, `skip_file_suffixes` and `skip_directories` - Wire the two new settings up to usvfs - Add two new buttons to the `Workarounds` dialog, one to adjust Skip File Suffixes and another for Skip Directories, both buttons act nearly identical to the Executable Blacklist button - Add a new grouping in the `Workarounds` dialog box that contains the usvfs buttons to keep the dialog a tad organized # Results
Holt59
reviewed
May 28, 2024
Holt59
reviewed
May 28, 2024
# Conflicts: # src/usvfsconnector.cpp
Holt59
reviewed
Jun 12, 2024
Member
|
Code looks good to me, I will try to do a build with it later today to see how it renders live. |
Al12rs
reviewed
Jun 14, 2024
Al12rs
previously approved these changes
Jun 14, 2024
Member
Al12rs
left a comment
There was a problem hiding this comment.
The relevant code looks good to me.
Contributor
Author
|
Clang-formatted & updated from the default branch, not sure if that's why the build failed or if the build action is flaky sometimes. |
Al12rs
approved these changes
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
ModOrganizer2/usvfs#61 Highlights some reasons why the ability to skip files & directories would be beneficial
ModOrganizer2/usvfs#61 Is also required first before this PR can merged or built
Modifications
skip_file_suffixesandskip_directoriesWorkaroundsdialog, one to adjust Skip File Suffixes and another for Skip Directories, both buttons act nearly identical to the Executable Blacklist buttonWorkaroundsdialog box that contains the usvfs buttons to keep the dialog a tad organizedResults