Skip to content

Consistent file names in Alpine-related snippet #4104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MightyPen merged 1 commit into from
Feb 10, 2020
Merged

Consistent file names in Alpine-related snippet #4104

MightyPen merged 1 commit into from
Feb 10, 2020

Conversation

@estambakio-sc
Copy link
Contributor

@estambakio-sc estambakio-sc commented Feb 7, 2020

This commit fixes file names in Alpine-related snippet.

@PRMerger6 PRMerger6 requested a review from MightyPen February 7, 2020 14:03
@PRMerger6
Copy link
Contributor

PRMerger6 commented Feb 7, 2020

@estambakio-sc : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver ktoliver added the aq-pr-triaged tracking label for the PR review team label Feb 7, 2020
@MightyPen
Copy link
Contributor

MightyPen commented Feb 9, 2020

@David-Engel Hi David, Do you have any assessment of this PR #4104 ?
Thanks.

@MightyPen MightyPen mentioned this pull request Feb 9, 2020
Closed
@MightyPen
Copy link
Contributor

MightyPen commented Feb 10, 2020

@v-makouz Hi again Maxim, here is another PR, #4104, that is somewhat like PR #4070, and which also needs you to asses / Close / Merge etc.

Thanks. GeneMi = MightyPen

@MightyPen MightyPen requested review from v-makouz and removed request for MightyPen February 10, 2020 22:21
@MightyPen
Copy link
Contributor

MightyPen commented Feb 10, 2020

@estambakio-sc Hello Egor, We like this PR #4104, and are now merging it.
Thank you very much for providing the important updates to us.

Thank you for submitting this PR. We hope to hear from you again.

@MightyPen MightyPen merged commit 68c0772 into MicrosoftDocs:live Feb 10, 2020
MightyPen added a commit that referenced this pull request Feb 10, 2020
@MightyPen
Add gpg, add -O
297243e 
This public PR is created by GeneMi (MightyPen) and v-Makouz. This purposely follows merged public PR #4104 (PR #4070 was rejected, kinda).
@MightyPen
Copy link
Contributor

MightyPen commented Feb 10, 2020

Just now, v-Makouz and I (GeneMi) further updated this article, with the following Commit here in the public repo:

  • https://github.com/MicrosoftDocs/sql-docs/commit/297243e5688fdba4a988b903dfc66925d48dc56a#diff-f7c89af2a4f2093d966dce03e08938cf

Thanks.

@estambakio-sc estambakio-sc deleted the patch-1 branch February 12, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v-makouz v-makouz Awaiting requested review from v-makouz

Assignees

@MightyPen MightyPen

Labels

aq-pr-triaged tracking label for the PR review team Change sent to author connectivity/tech do-not-merge sql/prod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estambakio-sc @PRMerger6 @MightyPen @ktoliver