-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fixed typo in Alpine download URLs in ODBC Driver installation page #4070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pezia : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Maybe this could be improved further by adding -O to the curl commands to actually save the files. |
|
@David-Engel Hi again David, Can you pass judgment on this PR #4070, which like PR #4104 is about ODBC in the context Linux-Mac. Thanks. G |
* Added -O to curl commands to actually save the files * Added signature check of MSSQL Tools
|
@pezia : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
@v-makouz Hello Maxim, Can you please process this customer-create "public" Pull Request #4070. Maxim, we need you to either (A) Resolve the conflicts here (or MS Teams chat with me while you watch me Resolve), or (B) Ask me to Close this PR and give the reason (such as Incorrect change proposal, or outdated, or...?). Thank you. (GeneMi = MightyPen) cc: @pezia |
|
@MightyPen Adding Also the version for tools should change to 17.5.1.2 (this is a recent fix, so it wasn't in the original doc) For the conflict, you can either resolve it here with those changes, or you can close this PR and I'll make another one with all the changes (-O, package name, tools verify, and tools version) whichever is easier |
|
@pezia Hello Zsolt, We like part of your PR #4070, but we do not want all parts of it. Thank you for submitting this PR, it is very helpful. We hope to hear from you again. |
No description provided.