Skip to content

Improve token api client#517

Merged
xavier-brochard merged 4 commits intomainfrom
improve-token-api-client
Sep 5, 2025
Merged

Improve token api client#517
xavier-brochard merged 4 commits intomainfrom
improve-token-api-client

Conversation

@xavier-brochard
Copy link
Copy Markdown
Contributor

@xavier-brochard xavier-brochard commented Sep 5, 2025

  • Fixes an issue that caused to show an empty symbol instead of UNKNOWN for tokens with no metadata in the activity list
  • Simplify some code flows by removing the TokenMetadataService (that was not achieving much) in favor of a direct use of TokenApiClient.

ulissesferreira
ulissesferreira previously approved these changes Sep 5, 2025
zone-live
zone-live previously approved these changes Sep 5, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 5, 2025

@xavier-brochard xavier-brochard merged commit 1a9ad08 into main Sep 5, 2025
10 checks passed
@xavier-brochard xavier-brochard deleted the improve-token-api-client branch September 5, 2025 11:50
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Sep 5, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana Wallet Snap to its latest version `2.3.7`.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Added support to Solana tokens with multiplier
([#509](MetaMask/snap-solana-wallet#509))
CHANGELOG entry: Fix a bug that was causing to show spam Solana
transactions in the activity list
([#515](MetaMask/snap-solana-wallet#515))
CHANGELOG entry: Fixed an issue that was causing to show an empty symbol
instead of `UNKNOWN` in activity list for Solana tokens with no metadata
([#517](MetaMask/snap-solana-wallet#517))

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
github-merge-queue bot pushed a commit to MetaMask/metamask-mobile that referenced this pull request Sep 5, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana Wallet Snap to its latest version `2.3.7`.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Added support to Solana tokens with multiplier
([#509](MetaMask/snap-solana-wallet#509))
CHANGELOG entry: Fix a bug that was causing to show spam Solana
transactions in the activity list
([#515](MetaMask/snap-solana-wallet#515))
CHANGELOG entry: Fixed an issue that was causing to show an empty symbol
instead of `UNKNOWN` in activity list for Solana tokens with no metadata
([#517](MetaMask/snap-solana-wallet#517))

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants