Skip to content

Upgraded to React Native 0.59 & Pin deps to exact version#515

Merged
brunobar79 merged 8 commits intodevelopfrom
react-native-0.59
Mar 14, 2019
Merged

Upgraded to React Native 0.59 & Pin deps to exact version#515
brunobar79 merged 8 commits intodevelopfrom
react-native-0.59

Conversation

@brunobar79
Copy link
Copy Markdown
Contributor

@brunobar79 brunobar79 commented Mar 13, 2019

@brunobar79 brunobar79 changed the title React native 0.59 React Native 0.59 Mar 13, 2019
@brunobar79 brunobar79 changed the title React Native 0.59 Upgraded to . React Native 0.59 and Pin deps to exact version Mar 13, 2019
@brunobar79 brunobar79 requested a review from estebanmino March 13, 2019 20:23
@brunobar79 brunobar79 changed the title Upgraded to . React Native 0.59 and Pin deps to exact version Upgraded to React Native 0.59 & Pin deps to exact version Mar 13, 2019
Copy link
Copy Markdown
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunobar79 brunobar79 merged commit 69381f0 into develop Mar 14, 2019
@brunobar79 brunobar79 deleted the react-native-0.59 branch July 22, 2019 18:13
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* remove jsc-android required changes

* working

* working

* working

* tests green AF

* fix linter errors

* turn on inline requires
github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana Wallet Snap to its latest version `2.3.7`.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Added support to Solana tokens with multiplier
([#509](MetaMask/snap-solana-wallet#509))
CHANGELOG entry: Fix a bug that was causing to show spam Solana
transactions in the activity list
([#515](MetaMask/snap-solana-wallet#515))
CHANGELOG entry: Fixed an issue that was causing to show an empty symbol
instead of `UNKNOWN` in activity list for Solana tokens with no metadata
([#517](MetaMask/snap-solana-wallet#517))

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants