Skip to content

chore: bump deps, move network-controller to direct dep#254

Merged
cryptodev-2s merged 2 commits intomainfrom
chore/bump-deps-remove-error-reporting-service
Mar 20, 2026
Merged

chore: bump deps, move network-controller to direct dep#254
cryptodev-2s merged 2 commits intomainfrom
chore/bump-deps-remove-error-reporting-service

Conversation

@cryptodev-2s
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s commented Mar 19, 2026

What

  • Move @metamask/network-controller from peer to direct dependency and bump ^25 → ^30
  • Bump @metamask/utils from ^9.2.1 → ^11.0.0
  • Remove unused @metamask/error-reporting-service peer and dev dependency
  • Add skipLibCheck: true to tsconfig (fixes transitive type errors from exactOptionalPropertyTypes)

Why

Aligning dependencies with the latest core packages. @metamask/error-reporting-service was never imported — only listed as a peer dependency — and is now deprecated.


Note

Medium Risk
Moderate risk due to a major-version bump of @metamask/network-controller and @metamask/utils, which can introduce runtime or type-level breaking changes despite no app code modifications.

Overview
Updates dependency management by moving @metamask/network-controller from peerDependencies/devDependencies to a direct dependencies entry and bumping it to ^30.0.0, and by bumping @metamask/utils to ^11.0.0.

Removes @metamask/error-reporting-service from package manifests (no in-repo references found), enables skipLibCheck in tsconfig.json to avoid transitive type-check failures, and refreshes yarn.lock accordingly. Also records the dependency changes in the CHANGELOG.

Written by Cursor Bugbot for commit b97f8b6. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s requested a review from a team as a code owner March 19, 2026 19:50
@cryptodev-2s cryptodev-2s self-assigned this Mar 19, 2026
@cryptodev-2s cryptodev-2s requested a review from a team March 19, 2026 19:50
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 19, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​controller-utils@​11.14.1 ⏵ 11.19.097 -110077 +194 +1100
Updated@​metamask/​utils@​9.2.1 ⏵ 11.10.09810094 +190 -1100
Updated@​metamask/​network-controller@​25.0.0 ⏵ 30.0.0100 +4100100 +23100 +5100

View full report

@cryptodev-2s cryptodev-2s force-pushed the chore/bump-deps-remove-error-reporting-service branch from 72d2745 to 78a9361 Compare March 19, 2026 19:50
Copy link
Copy Markdown
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to check the changelogs for these to confirm no breaking changes, but left a comment in the meantime.

@cryptodev-2s cryptodev-2s requested a review from mcmire March 20, 2026 08:11
Copy link
Copy Markdown
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cryptodev-2s cryptodev-2s merged commit 1c270d6 into main Mar 20, 2026
18 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/bump-deps-remove-error-reporting-service branch March 20, 2026 14:37
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Mar 23, 2026
## **Description**

Bump the following packages:

### `@metamask/chain-agnostic-permission` `^1.3.0` → `^1.4.0`

[Changelog](https://github.com/MetaMask/core/blob/main/packages/chain-agnostic-permission/CHANGELOG.md#140)
- **Added:** `Bip122AccountChangedNotifications` property in
`KnownSessionProperties` enum
([#7537](MetaMask/core#7537))
- **Changed:** Remove `@metamask/network-controller` dependency
([#7561](MetaMask/core#7561))
- **Changed:** Dependency bumps (`@metamask/utils`,
`@metamask/controller-utils`, `@metamask/permission-controller`)

### `@metamask/multichain-api-middleware` `^1.2.5` → `^1.2.7`

[Changelog](https://github.com/MetaMask/core/blob/main/packages/multichain-api-middleware/CHANGELOG.md#127)
- **v1.2.7:** Dependency bumps (`network-controller` ^30.0.0,
`json-rpc-engine`, `multichain-transactions-controller`,
`controller-utils`)
- **v1.2.6 Fixed:** `wallet_revokeSession` to handle cases where
`params` is not provided
([#7551](MetaMask/core#7551))
- **v1.2.6 Changed:** Dependency bumps (`json-rpc-engine`, `utils`,
`network-controller`, `controller-utils`, `permission-controller`,
`chain-agnostic-permission`)

### `@metamask/ppom-validator` `0.39.0` → `0.39.1`

[Changelog](https://github.com/MetaMask/ppom-validator/blob/main/CHANGELOG.md#0391)
- **Changed:** Move `@metamask/network-controller` from peer to direct
dependency and bump ^25.0.0 → ^30.0.0
([#254](MetaMask/ppom-validator#254))
- **Changed:** Bump `@metamask/utils` from `^9.2.1` to `^11.0.0`
([#254](MetaMask/ppom-validator#254))

### `@metamask/selected-network-controller` `^25.0.0` → `^26.0.3`

[Changelog](https://github.com/MetaMask/core/blob/main/packages/selected-network-controller/CHANGELOG.md#2600)
- **v26.0.0 BREAKING:** Use `InternalProvider` instead of
`SafeEventEmitterProvider`
([#6796](MetaMask/core#6796))
- **v26.0.0 BREAKING:** Bump `@metamask/network-controller` from ^25.0.0
to ^26.0.0 ([#7202](MetaMask/core#7202))
- **v26.0.1:** Move peer dependencies to direct dependencies
(`network-controller`, `permission-controller`)
([#7209](MetaMask/core#7209))
- **v26.0.2–v26.0.3:** Dependency bumps (`network-controller` to
^30.0.0, `json-rpc-engine`)

No code changes required — breaking changes are internal to the packages
and don't affect extension usage. All dependency versions are already
compatible.

## **Changelog**

CHANGELOG entry: null

## **Related issues**

Fixes: N/A

## **Manual testing steps**

1. Build the extension and verify it runs correctly
2. Confirm no type errors are introduced

## **Screenshots/Recordings**

N/A — dependency-only changes

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Dependency-only update, but it upgrades core
networking/permission-related packages (e.g.,
`@metamask/selected-network-controller` and transitive
`@metamask/network-controller`/RPC middleware), which can subtly affect
session/network behavior at runtime.
> 
> **Overview**
> Bumps several MetaMask core dependencies:
`@metamask/chain-agnostic-permission` to `^1.4.0`,
`@metamask/multichain-api-middleware` to `^1.2.7`,
`@metamask/ppom-validator` to `0.39.1`, and
`@metamask/selected-network-controller` to `^26.0.3`.
> 
> Updates `yarn.lock` accordingly, including transitive shifts such as
`@metamask/network-controller` moving to `^30.0.0` in dependent packages
and related RPC middleware/util version bumps.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
133258b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants