fix: update wallet_revokeSession to handle cases where params is not provided#7551
Merged
ffmcgee725 merged 2 commits intomainfrom Jan 6, 2026
Merged
fix: update wallet_revokeSession to handle cases where params is not provided#7551ffmcgee725 merged 2 commits intomainfrom
wallet_revokeSession to handle cases where params is not provided#7551ffmcgee725 merged 2 commits intomainfrom
Conversation
Member
Author
|
@metamaskbot publish-preview |
jiexi
approved these changes
Jan 6, 2026
7 tasks
github-merge-queue Bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 23, 2026
## **Description** Bump the following packages: ### `@metamask/chain-agnostic-permission` `^1.3.0` → `^1.4.0` [Changelog](https://github.com/MetaMask/core/blob/main/packages/chain-agnostic-permission/CHANGELOG.md#140) - **Added:** `Bip122AccountChangedNotifications` property in `KnownSessionProperties` enum ([#7537](MetaMask/core#7537)) - **Changed:** Remove `@metamask/network-controller` dependency ([#7561](MetaMask/core#7561)) - **Changed:** Dependency bumps (`@metamask/utils`, `@metamask/controller-utils`, `@metamask/permission-controller`) ### `@metamask/multichain-api-middleware` `^1.2.5` → `^1.2.7` [Changelog](https://github.com/MetaMask/core/blob/main/packages/multichain-api-middleware/CHANGELOG.md#127) - **v1.2.7:** Dependency bumps (`network-controller` ^30.0.0, `json-rpc-engine`, `multichain-transactions-controller`, `controller-utils`) - **v1.2.6 Fixed:** `wallet_revokeSession` to handle cases where `params` is not provided ([#7551](MetaMask/core#7551)) - **v1.2.6 Changed:** Dependency bumps (`json-rpc-engine`, `utils`, `network-controller`, `controller-utils`, `permission-controller`, `chain-agnostic-permission`) ### `@metamask/ppom-validator` `0.39.0` → `0.39.1` [Changelog](https://github.com/MetaMask/ppom-validator/blob/main/CHANGELOG.md#0391) - **Changed:** Move `@metamask/network-controller` from peer to direct dependency and bump ^25.0.0 → ^30.0.0 ([#254](MetaMask/ppom-validator#254)) - **Changed:** Bump `@metamask/utils` from `^9.2.1` to `^11.0.0` ([#254](MetaMask/ppom-validator#254)) ### `@metamask/selected-network-controller` `^25.0.0` → `^26.0.3` [Changelog](https://github.com/MetaMask/core/blob/main/packages/selected-network-controller/CHANGELOG.md#2600) - **v26.0.0 BREAKING:** Use `InternalProvider` instead of `SafeEventEmitterProvider` ([#6796](MetaMask/core#6796)) - **v26.0.0 BREAKING:** Bump `@metamask/network-controller` from ^25.0.0 to ^26.0.0 ([#7202](MetaMask/core#7202)) - **v26.0.1:** Move peer dependencies to direct dependencies (`network-controller`, `permission-controller`) ([#7209](MetaMask/core#7209)) - **v26.0.2–v26.0.3:** Dependency bumps (`network-controller` to ^30.0.0, `json-rpc-engine`) No code changes required — breaking changes are internal to the packages and don't affect extension usage. All dependency versions are already compatible. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: N/A ## **Manual testing steps** 1. Build the extension and verify it runs correctly 2. Confirm no type errors are introduced ## **Screenshots/Recordings** N/A — dependency-only changes ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Dependency-only update, but it upgrades core networking/permission-related packages (e.g., `@metamask/selected-network-controller` and transitive `@metamask/network-controller`/RPC middleware), which can subtly affect session/network behavior at runtime. > > **Overview** > Bumps several MetaMask core dependencies: `@metamask/chain-agnostic-permission` to `^1.4.0`, `@metamask/multichain-api-middleware` to `^1.2.7`, `@metamask/ppom-validator` to `0.39.1`, and `@metamask/selected-network-controller` to `^26.0.3`. > > Updates `yarn.lock` accordingly, including transitive shifts such as `@metamask/network-controller` moving to `^30.0.0` in dependent packages and related RPC middleware/util version bumps. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 133258b. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Previously, the
wallet_revokeSessionfunction should called with aparamsvalue, otherwise it will throw an error due to trying to accessscopesonundefined.This PR updates the function to handle cases where
paramsis not provided, preventing it from throwing an error.References
Checklist
Note
Ensures
wallet_revokeSessionno longer throws whenparamsis omitted and continues to revoke permissions correctly.request.params?.scopes?.lengthand passrequest.params.scopesto partial revokeparamsis not provided and response remainstrueCHANGELOG.mdunder Unreleased > Fixed to document the fixWritten by Cursor Bugbot for commit 3b30181. This will update automatically on new commits. Configure here.