Skip to content

fix: Prevent SES errors in iOS dev builds#7924

Merged
Gudahtt merged 1 commit into
mainfrom
disable-ses-in-dev-mode
Nov 24, 2023
Merged

fix: Prevent SES errors in iOS dev builds#7924
Gudahtt merged 1 commit into
mainfrom
disable-ses-in-dev-mode

Conversation

@Gudahtt

@Gudahtt Gudahtt commented Nov 23, 2023 •
edited by leotm
Loading

Copy link
Copy Markdown
Member

Description

SES is now disabled in development builds. This was done as a workaround to various incompatibilities between SES and React development libraries, which were causing a SES error whenever a warning or error was triggered in an iOS dev build.

Related issues

Fixes #7923

Manual testing steps

Follow the reproduction steps for this issue: #7920

Screenshots/Recordings

Before:

Screenshot 2023-11-23 at 7 00 47 PM

After:

Screenshot 2023-11-23 at 6 54 32 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-mobile-platform Mobile Platform team labels Nov 23, 2023
@Gudahtt Gudahtt marked this pull request as ready for review November 23, 2023 22:32
@Gudahtt Gudahtt requested a review from a team as a code owner November 23, 2023 22:32
@Gudahtt Gudahtt changed the title Fix: Prevent SES errors in iOS dev builds fix: Prevent SES errors in iOS dev builds Nov 23, 2023
@github-actions

github-actions Bot commented Nov 23, 2023

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28594618-dbbb-4655-ad9d-4e04e761ccd6
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter

codecov-commenter commented Nov 23, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54f3754) 37.39% compared to head (50d7065) 37.39%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7924   +/-   ##
=======================================
  Coverage   37.39%   37.39%           
=======================================
  Files        1052     1052           
  Lines       28175    28175           
  Branches     2517     2517           
=======================================
  Hits        10536    10536           
  Misses      17040    17040           
  Partials      599      599

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt
Fix: Prevent SES errors in iOS dev builds
50d7065 
SES is now disabled in development builds. This was done as a
workaround to various incompatibilities between SES and React
development libraries, which were causing a SES error whenever a
warning or error was triggered in an iOS dev build.

Fixes #7923
@Gudahtt Gudahtt force-pushed the disable-ses-in-dev-mode branch from ea01697 to 50d7065 Compare November 24, 2023 12:51
@sonarqubecloud

sonarqubecloud Bot commented Nov 24, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leotm

leotm commented Nov 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

tested in-app (metamask.github.io/test-dapp) on 69c79df

Screenshot 2023-11-24 at 2 34 25 pm

before:

Screenshot 2023-11-24 at 2 28 58 pm

after:

Screenshot 2023-11-24 at 2 30 08 pm

@Gudahtt Gudahtt added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 24, 2023
@Gudahtt Gudahtt merged commit 0163b8b into main Nov 24, 2023
@Gudahtt Gudahtt deleted the disable-ses-in-dev-mode branch November 24, 2023 15:04
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 24, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@leotm leotm leotm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.13.0 Issue or pull request that will be included in release 7.13.0 team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: iOS Development build warnings/errors trigger SES error

4 participants

@Gudahtt @codecov-commenter @leotm @metamaskbot