Skip to content

[Bug]: iOS Development build warnings/errors trigger SES error #7923

@Gudahtt

Description

@Gudahtt

Describe the bug

Any warnings or errors in development builds are triggering an error from ses. The error is "Attempting to define a property on object that is not extensible", and it comes from a module in the react package that is only used for development builds. This error hides the underlying error/warning, making local development much more difficult.

Various development-build-only dependencies are not compatible with SES lockdown. On the MetaMask extension we worked around this by not calling lockdown in development builds. We should consider doing the same thing here.

Expected behavior

Errors and warnings should not trigger additional errors.

Screenshots/Recordings

Screenshot 2023-11-23 at 7 00 47 PM

Steps to reproduce

Follow the reproduction steps for this issue: #7920

Error messages or log output

 ERROR  TypeError: Attempting to define property on object that is not extensible.

This error is located at:
    in Unknown (created by SignatureRequest)
    in RCTView (created by View)
    in View (created by AnimatedComponent)
    ...

Version

main

Build type

None

Device

iPhone 13 Pro simulator

Operating system

iOS

Additional context

No response

Severity

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    release-7.13.0Issue or pull request that will be included in release 7.13.0type-bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions