Skip to content

[Bug]: Crash when signing message #7920

@Gudahtt

Description

@Gudahtt

Describe the bug

The application crashes when signing an eth_signTypedData_v4 message on the main branch. Various Bitrise test runs hint that the same is true of other types of messages as well.

Expected behavior

The application should not crash when signing a message

Screenshots/Recordings

Screenshot 2023-11-23 at 10 11 02 AM

Steps to reproduce

  • Navigate to https://metamask.github.io/test-dapp using a build from main (tested with 69c79df)
    • I have tested this with a development build, I am not sure if that matters for this reproduction though
  • Connect an account to the dapp
  • Trigger an eth_signTypedData_v4 signature, and the application with crash

Error messages or log output

Initially the error shown is Attempting to define a property on object that is not extensible. However this error is itself caused by the underlying error, and is related to ses.

I removed ses locally to find the underlying error here, which was _imageSource$uri.endsWith is not a function. It is from this line:

(imageSource.uri?.endsWith('.svg') ||

Version

69c79df

Build type

None

Device

iPhone 13 Pro simulator

Operating system

iOS

Additional context

No response

Severity

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions