-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Closed
Labels
type-bugSomething isn't workingSomething isn't working
Description
Describe the bug
The application crashes when signing an eth_signTypedData_v4 message on the main branch. Various Bitrise test runs hint that the same is true of other types of messages as well.
Expected behavior
The application should not crash when signing a message
Screenshots/Recordings
Steps to reproduce
- Navigate to https://metamask.github.io/test-dapp using a build from
main(tested with 69c79df)- I have tested this with a development build, I am not sure if that matters for this reproduction though
- Connect an account to the dapp
- Trigger an
eth_signTypedData_v4signature, and the application with crash
Error messages or log output
Initially the error shown is Attempting to define a property on object that is not extensible. However this error is itself caused by the underlying error, and is related to ses.
I removed ses locally to find the underlying error here, which was _imageSource$uri.endsWith is not a function. It is from this line:
metamask-mobile/app/util/favicon/index.ts
Line 163 in 69c79df
| (imageSource.uri?.endsWith('.svg') || |
Version
Build type
None
Device
iPhone 13 Pro simulator
Operating system
iOS
Additional context
No response
Severity
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type-bugSomething isn't workingSomething isn't working