Skip to content

fix: prevent undefined title#5999

Closed
abretonc7s wants to merge 1 commit intomainfrom
fix/5957-undefined-host-substr
Closed

fix: prevent undefined title#5999
abretonc7s wants to merge 1 commit intomainfrom
fix/5957-undefined-host-substr

Conversation

@abretonc7s
Copy link
Copy Markdown
Contributor

@abretonc7s abretonc7s commented Mar 20, 2023

Fixes issue when title is not defined.

image

To reproduce the issue:

  • Go to app.uniswap.org from the Chrome browser
  • Initiate a connection with Metamask
  • Start a swap from Eth to an ERC20 token
  • Sign the transaction
  • See the error

Expected behavior: App should work normally after signing a transaction

Fixes: #5989
Also related to: #5957 that's been fixed on the iOS SDK side

@abretonc7s abretonc7s requested a review from a team as a code owner March 20, 2023 14:43
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added Code Impact - Low Minor code change that can safely applied to the codebase needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 20, 2023
@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 20, 2023
@christopherferreira9
Copy link
Copy Markdown
Contributor

christopherferreira9 commented Mar 28, 2023

Hi @abretonc7s .
This is now giving me the error below:
Screenshot 2023-03-28 at 12 40 24

This happens before signing the approval in MetaMask

@christopherferreira9 christopherferreira9 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Mar 28, 2023
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Jun 26, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 3, 2023

This PR was closed because it has been stalled for 7 days with no activity. Thank you for your contributions.

@github-actions github-actions bot closed this Jul 3, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jul 8, 2025
## **Description**

This PR bumps:
- `@metamask/profile-sync-controller` to `^20.0.0`

Updates from the package changelog since `^18.0.0`:

```md
## [20.0.0]

### Added

- Add new `AuthenticationController:getUserProfileMetaMetrics` method ([#6068](MetaMask/core#6068))
  - This method fetches data using the Authentication API, returning all MetaMetrics sessions related to the currently authenticated user, in the form of `typeof UserProfileMetaMetrics`

### Changed

- **BREAKING:** Bump peer dependency `@metamask/snaps-controllers` from `^12.0.0` to `^14.0.0` ([#6035](MetaMask/core#6035))
- Bump `@metamask/snaps-sdk` from `^7.1.0` to `^9.0.0` ([#6035](MetaMask/core#6035))
- Bump `@metamask/snaps-utils` from `^9.4.0` to `^11.0.0` ([#6035](MetaMask/core#6035))

## [19.0.0]

### Changed

- **BREAKING:** Bump peer dependency `@metamask/accounts-controller` to `^31.0.0` ([#5999](MetaMask/core#5999))
- **BREAKING:** Bump peer dependency `@metamask/network-controller` to `^24.0.0` ([#5999](MetaMask/core#5999))
```

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Impact - Low Minor code change that can safely applied to the codebase QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed stale Issues that have not had activity in the last 90 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: undefined is not an object (evaluating '(0,r(d[11]).getHost)(p).substr')

3 participants