Skip to content

UI updates#519

Merged
estebanmino merged 7 commits intodevelopfrom
ui-updates
Mar 14, 2019
Merged

UI updates#519
estebanmino merged 7 commits intodevelopfrom
ui-updates

Conversation

@estebanmino
Copy link
Copy Markdown
Contributor

Description

This PR

  • Updates search input in browser home
  • Fixes clicking on an autocomplete option crashing the app
  • Removes QR icon

Mrb2NG9yYi

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #511
Resolves #508

Copy link
Copy Markdown
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@estebanmino estebanmino merged commit 4827665 into develop Mar 14, 2019
@estebanmino estebanmino deleted the ui-updates branch March 14, 2019 21:57
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* browser search update

* fix url autocomplete

* remove qr from drawer

* snapshots

* qr and search margin

* on receive

* snapshopts
github-merge-queue bot pushed a commit that referenced this pull request Sep 8, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR bumps the Solana snap to its latest version.

## **Changelog**

CHANGELOG entry: Notify client when native SOL balance reaches zero
([#519](MetaMask/snap-solana-wallet#519))

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants