Skip to content

fix: notify the client when native balance goes to zero#19389

Merged
xavier-brochard merged 1 commit intomainfrom
solana-snap-notify-client-account-zero-balance
Sep 8, 2025
Merged

fix: notify the client when native balance goes to zero#19389
xavier-brochard merged 1 commit intomainfrom
solana-snap-notify-client-account-zero-balance

Conversation

@xavier-brochard
Copy link
Copy Markdown
Contributor

@xavier-brochard xavier-brochard commented Sep 8, 2025

Description

This PR bumps the Solana snap to its latest version.

Changelog

CHANGELOG entry: Notify client when native SOL balance reaches zero (#519)

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-networks Networks team label Sep 8, 2025
@xavier-brochard xavier-brochard added No QA Needed Apply this label when your PR does not need any QA effort. and removed team-networks Networks team labels Sep 8, 2025
@socket-security
Copy link
Copy Markdown

socket-security bot commented Sep 8, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​solana-wallet-snap@​2.3.7 ⏵ 2.3.8100 +110088100 +1100

View full report

@xavier-brochard xavier-brochard added team-networks Networks team No QA Needed Apply this label when your PR does not need any QA effort. and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Sep 8, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 8, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bac5085
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/840cf4e1-baea-40e6-969c-b7cc47d2ab79

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@xavier-brochard xavier-brochard added this pull request to the merge queue Sep 8, 2025
Merged via the queue into main with commit bd4688f Sep 8, 2025
187 of 199 checks passed
@xavier-brochard xavier-brochard deleted the solana-snap-notify-client-account-zero-balance branch September 8, 2025 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
@metamaskbot metamaskbot added the release-7.56.0 Issue or pull request that will be included in release 7.56.0 label Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ulissesferreira ulissesferreira ulissesferreira approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-XS team-networks Networks team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xavier-brochard @ulissesferreira @metamaskbot