Skip to content

chore: remove unused @metamask/error-reporting-service#28027

Merged
cryptodev-2s merged 1 commit into
mainfrom
chore/remove-unused-error-reporting-service
Mar 27, 2026
Merged

chore: remove unused @metamask/error-reporting-service#28027
cryptodev-2s merged 1 commit into
mainfrom
chore/remove-unused-error-reporting-service

Conversation

@cryptodev-2s

@cryptodev-2s cryptodev-2s commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the @metamask/error-reporting-service package. This service registered a ErrorReportingService:captureException messenger action, but no controller ever called it. Error reporting is now handled directly via the built-in messenger.captureException method in @metamask/messenger.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

Feature: App startup

  Scenario: user opens the app after removing error-reporting-service
    Given the app is built from this branch

    When user launches the app
    Then the app starts without errors

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: removes an unused controller/messenger layer and its dependency, with no functional logic changes beyond no longer instantiating ErrorReportingService. Main risk is any hidden reliance on the removed messenger namespace/action at runtime.

Overview
Removes the unused @metamask/error-reporting-service integration by deleting its controller init and messenger wiring, and by dropping ErrorReportingService from Engine controller initialization and associated type unions.

Updates dependencies by removing @metamask/error-reporting-service from package.json and yarn.lock, and deletes the related unit tests.

Written by Cursor Bugbot for commit f95f656. This will update automatically on new commits. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Mar 27, 2026
@cryptodev-2s cryptodev-2s marked this pull request as ready for review March 27, 2026 11:06
@cryptodev-2s cryptodev-2s requested a review from a team as a code owner March 27, 2026 11:06
@cryptodev-2s cryptodev-2s self-assigned this Mar 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - draft PR

All E2E tests pre-selected.

View GitHub Actions results

@cryptodev-2s cryptodev-2s changed the title chore: remove unused @metamask/error-reporting-service chore: remove unused @metamask/error-reporting-service Mar 27, 2026
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@cryptodev-2s cryptodev-2s enabled auto-merge March 27, 2026 11:43
github-merge-queue Bot pushed a commit to MetaMask/core that referenced this pull request Mar 27, 2026
## Explanation

Removes the `@metamask/error-reporting-service` package from the
monorepo. Its `captureException` messenger action has been replaced by
the built-in `messenger.captureException` in `@metamask/messenger`. Both
extension and mobile have already removed their dependency on this
package:

- Extension: MetaMask/metamask-extension#41301
- Mobile: MetaMask/metamask-mobile#28027

## References

N/A

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Moderate risk because it deletes a published workspace package and
removes TS project references, which could break any downstream
consumers still importing it or relying on its build outputs.
> 
> **Overview**
> Removes the deprecated `@metamask/error-reporting-service` package
from the repo (source, tests, configs, and metadata) now that error
reporting is handled via `Messenger.captureException`.
> 
> Cleans up monorepo wiring by dropping the package from `README.md`
lists/graphs, `CODEOWNERS`/`teams.json`, ESLint suppressions, TypeScript
project references (`tsconfig*.json`), and `yarn.lock` workspace
entries.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e9bfd81. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit e31b7a5 Mar 27, 2026
225 of 227 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/remove-unused-error-reporting-service branch March 27, 2026 15:40
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2026
@metamaskbot metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.73.0 Issue or pull request that will be included in release 7.73.0 size-M team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants