chore: remove unused `@metamask/error-reporting-service` by cryptodev-2s · Pull Request #41301 · MetaMask/metamask-extension

cryptodev-2s · 2026-03-27T10:57:05Z

Description

Removes the @metamask/error-reporting-service package. This service registered a ErrorReportingService:captureException messenger action, but no controller ever called it. Error reporting is now handled directly via messenger.captureException, which is a built-in capability of @metamask/messenger (used e.g. in oauth-service.ts), making this package redundant.

Changelog

CHANGELOG entry: null

Related issues

N/A

Manual testing steps

Build the extension and verify it starts without errors.

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk cleanup that removes an unused controller/messenger and dependency; main risk is missing any hidden runtime references during initialization.

Overview
Removes the redundant ErrorReportingService controller: deletes its init + messenger modules/tests, and drops it from controller/messenger registration and metamask-controller initialization.

Also removes the @metamask/error-reporting-service dependency from package.json/yarn.lock and cleans up the related deprecation ignore entry in .yarnrc.yml.

^{Written by Cursor Bugbot for commit fe77e35. This will update automatically on new commits. Configure here.}

github-actions · 2026-03-27T10:57:13Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-03-27T11:40:22Z

Builds ready [fe77e35]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks

👆 Interaction Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Load New Account load_new_account 355 281 514 92 405 514
total 355 281 514 92 405 514
Confirm Tx confirm_tx 6092 6090 6093 1 6093 6093
total 6092 6090 6093 1 6093 6093
Bridge User Actions bridge_load_page 236 215 252 16 251 252
bridge_load_asset_picker 274 257 294 17 286 294
bridge_search_token 741 702 776 32 764 776
total 1273 1261 1285 10 1285 1285

🔌 Startup Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Chrome Browserify Startup Standard Home uiStartup 1528 1276 1935 114 1581 1753
load 1256 1030 1540 104 1321 1429
domContentLoaded 1246 1021 1532 103 1306 1415
domInteractive 32 16 114 22 29 89
firstPaint 255 78 1556 286 262 1155
backgroundConnect 223 199 273 13 228 249
firstReactRender 21 13 71 8 22 31
initialActions 1 0 5 1 1 4
loadScripts 1040 819 1320 102 1096 1203
setupStore 15 7 46 8 17 30
numNetworkReqs 39 31 88 17 31 86
Chrome Browserify Startup Power User Home uiStartup 5561 2041 16163 2933 5907 14155
load 1324 1149 2699 188 1369 1678
domContentLoaded 1302 1139 2654 179 1330 1618
domInteractive 35 19 155 26 33 75
firstPaint 218 85 1532 191 265 362
backgroundConnect 2596 314 12990 2803 3063 10969
firstReactRender 26 19 43 5 28 37
initialActions 1 0 4 1 1 3
loadScripts 1059 931 1452 111 1103 1271
setupStore 16 7 34 6 18 29
numNetworkReqs 298 98 489 78 335 399

🧭 User Journey Benchmarks
Benchmark Metric Mean (ms) Min (ms) Max (ms) Std Dev (ms) P75 (ms) P95 (ms)
Onboarding Import Wallet importWalletToSocialScreen 218 217 220 1 219 220
srpButtonToSrpForm 97 90 104 6 103 104
confirmSrpToPwForm 22 21 24 1 23 24
pwFormToMetricsScreen 15 15 16 0 15 16
metricsToWalletReadyScreen 16 15 16 0 16 16
doneButtonToHomeScreen 584 525 686 58 606 686
openAccountMenuToAccountListLoaded 2933 2916 2953 14 2948 2953
total 3864 3829 3891 25 3884 3891
Onboarding New Wallet createWalletToSocialScreen 219 217 222 2 221 222
srpButtonToPwForm 116 109 129 8 123 129
createPwToRecoveryScreen 8 8 8 0 8 8
skipBackupToMetricsScreen 39 38 42 2 39 42
agreeButtonToOnboardingSuccess 16 15 16 0 16 16
doneButtonToAssetList 553 366 676 109 633 676
total 955 759 1065 109 1044 1065
Asset Details assetClickToPriceChart 89 83 94 5 94 94
total 89 83 94 5 94 94
Solana Asset Details assetClickToPriceChart 63 46 95 18 72 95
total 63 46 95 18 72 95
Import Srp Home loginToHomeScreen 2296 2248 2370 50 2313 2370
openAccountMenuAfterLogin 100 65 149 38 142 149
homeAfterImportWithNewWallet 1625 339 2685 1018 2381 2685
total 4159 2767 5431 1129 5082 5431
Send Transactions openSendPageFromHome 46 25 76 23 71 76
selectTokenToSendFormLoaded 37 36 40 2 37 40
reviewTransactionToConfirmationPage 936 893 984 33 947 984
total 1007 990 1019 12 1019 1019
Swap openSwapPageFromHome 89 33 117 32 115 117
fetchAndDisplaySwapQuotes 2692 2683 2706 8 2694 2706
total 2781 2715 2821 39 2810 2821

🌐 Dapp Page Load Benchmarks

Current Commit: fe77e35 | Date: 3/27/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.04s (±65ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
domContentLoaded-> current mean value: 732ms (±59ms) 🟢 | historical mean value: 730ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 84ms (±10ms) 🟢 | historical mean value: 84ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	65ms	1.00s	1.32s	1.25s	1.32s
domContentLoaded	732ms	59ms	697ms	1.00s	932ms	1.00s
firstPaint	84ms	10ms	68ms	160ms	92ms	160ms
firstContentfulPaint	84ms	10ms	68ms	160ms	92ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚀 Bundle size reduced!]

background: -3.38 KiB (-0.05%)
ui: 9 Bytes (0%)
common: -7 Bytes (0%)

sonarqubecloud · 2026-03-27T11:55:44Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chore: remove unused @metamask/error-reporting-service

fe77e35

cryptodev-2s had a problem deploying to pr-comment March 27, 2026 10:57 — with GitHub Actions Error

metamaskbot added the team-core-platform Core Platform team label Mar 27, 2026

cryptodev-2s marked this pull request as ready for review March 27, 2026 10:57

cryptodev-2s requested a review from a team as a code owner March 27, 2026 10:57

cryptodev-2s self-assigned this Mar 27, 2026

cryptodev-2s temporarily deployed to pr-comment March 27, 2026 10:57 — with GitHub Actions Inactive

github-actions Bot added the size-M label Mar 27, 2026

FrederikBolding approved these changes Mar 27, 2026

View reviewed changes

cryptodev-2s mentioned this pull request Mar 27, 2026

chore: remove @metamask/error-reporting-service package MetaMask/core#8323

Merged

4 tasks

itsyoboieltr approved these changes Mar 27, 2026

View reviewed changes

cryptodev-2s changed the title ~~chore: remove unused @metamask/error-reporting-service~~ chore: remove unused @metamask/error-reporting-service Mar 27, 2026

cryptodev-2s temporarily deployed to pr-comment March 27, 2026 11:35 — with GitHub Actions Inactive

cryptodev-2s enabled auto-merge March 27, 2026 11:43

cryptodev-2s added this pull request to the merge queue Mar 27, 2026

Merged via the queue into main with commit 951cb40 Mar 27, 2026
592 of 599 checks passed

cryptodev-2s deleted the chore/remove-unused-error-reporting-service branch March 27, 2026 13:03

github-actions Bot locked and limited conversation to collaborators Mar 27, 2026

metamaskbot added the release-13.26.0 Issue or pull request that will be included in release 13.26.0 label Mar 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove unused `@metamask/error-reporting-service`#41301

chore: remove unused `@metamask/error-reporting-service`#41301
cryptodev-2s merged 1 commit into
mainfrom
chore/remove-unused-error-reporting-service

cryptodev-2s commented Mar 27, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

metamaskbotv2 Bot commented Mar 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud Bot commented Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cryptodev-2s commented Mar 27, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

metamaskbotv2 Bot commented Mar 27, 2026

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

sonarqubecloud Bot commented Mar 27, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cryptodev-2s commented Mar 27, 2026 •

edited by cursor Bot

Loading