Description

Fix Segment schema violations for user traits in identify calls:

• traits.security_providers: was sending string ('blockaid' / ''), now sends string[] (['blockaid'] / [])
• traits.has_marketing_consent: was sending string ('ON' / 'OFF'), now sends boolean (true / false)

Updated all call sites across the codebase (not just the generator function) to ensure consistent trait types.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #23970

Manual testing steps

Feature: Analytics user traits types

  Scenario: security_providers trait is sent as array
    Given the user has Blockaid security alerts enabled
    When an identify call is made to Segment
    Then the security_providers trait is sent as ['blockaid']

  Scenario: security_providers trait is empty array when disabled
    Given the user has Blockaid security alerts disabled
    When an identify call is made to Segment
    Then the security_providers trait is sent as []

  Scenario: has_marketing_consent trait is sent as boolean
    Given the user has opted in to marketing data collection
    When an identify call is made to Segment
    Then the has_marketing_consent trait is sent as true (not "ON")

Screenshots/Recordings

N/A — no UI changes, only analytics trait type fixes.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.