fix(analytics): fix user traits types violations #23970
Description
What is this about?
Segment schema violation for the following user traits in identify calls:
- traits.security_providers: Invalid type. Expected: array, given: string
- traits.has_marketing_consent: Invalid type. Expected: boolean, given: string
Scenario
No response
Design
No response
Technical Details
Update traits types to be
- traits.security_providers: array of provider strings ->
['blockaid']or[]see https://github.com/MetaMask/metamask-mobile/blob/refactor/22017_common_analytics_controller/app/util/metrics/UserSettingsAnalyticsMetaData/generateUserProfileAnalyticsMetaData.ts#L44-L45 - traits.has_marketing_consent: boolean -> https://github.com/MetaMask/metamask-mobile/blob/refactor/22017_common_analytics_controller/app/util/metrics/UserSettingsAnalyticsMetaData/generateUserProfileAnalyticsMetaData.ts#L46-L49
Threat Modeling Framework
No response
Acceptance Criteria
- no more schema violations reported on these traits
Stakeholder review needed before the work gets merged
- Engineering (needed in most cases)
- Design
- Product
- QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- Security
- Legal
- Marketing
- Management (please specify)
- Data