Merged
Conversation
123cbd8 to
e283439
Compare
estebanmino
approved these changes
Apr 8, 2021
Contributor
estebanmino
left a comment
There was a problem hiding this comment.
this was already approved the last time 😅
Contributor
Author
I know 😭 needed re-approval because of the revert |
ibrahimtaveras00
suggested changes
Apr 15, 2021
Contributor
ibrahimtaveras00
left a comment
There was a problem hiding this comment.
only one place looked off to me in terms of UX
The "Create a new wallet" flow on Wallet setup, the green arrow indicating the passwords match is misaligned
ibrahimtaveras00
approved these changes
Apr 15, 2021
Contributor
ibrahimtaveras00
left a comment
There was a problem hiding this comment.
All good now
QA Passed 👍🏽
3 tasks
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Fix AssetList typeface * Update BaseNotification text * Update ChoosePassword ImportFromSeed * Update styles * Update snapshots * Update snapshot * fix checkmark position * update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-opening this sine I merged #2201 too early my bad.
Description
Some design inconsistencies Christian brought up being addressed in this PR
This PR actually makes a lot of style updates so I will go through them:
The
baseStyles.blackhas been updated to not be absolute black.Type face updated in asset list for adding Tokens:
BaseNotificationcomponent: