Merged
Conversation
84e0306 to
0b9ba42
Compare
|
@rickycodes looks good! Just a bit of feedback on the import seed phrase screen regarding spacing and the font size of the form validation text. See below
|
Contributor
Author
|
@cjeria I've gone ahead and made the font size adjustments, re: spacing we might want to leave that as is for now? The feedback text isn't always present so increasing that spacing might look a bit odd in the empty cases here's what things look like now:
Let me know what you think. |
8df05d0 to
08071d0
Compare
|
LGTM! |
rickycodes
added a commit
that referenced
this pull request
Mar 11, 2021
This reverts commit 4be387a.
Merged
rickycodes
added a commit
that referenced
this pull request
Mar 11, 2021
Merged
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Fix fonts and add proper black * Update styles * Update styles for BaseNotification * Update snapshots * Update top fro checkmark * Update snapshot * Fix checkmark * Update snapshots * Reduce passwordStrengthLabel font size * Use MIN_PASSWORD_LENGTH * update snapshots
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some design inconsistencies Christian brought up being addressed in this PR
This PR actually makes a lot of style updates so I will go through them:
The
baseStyles.blackhas been updated to not be absolute black.Type face updated in asset list for adding Tokens:
BaseNotificationcomponent: