Feature/warn when replacing by rickycodes · Pull Request #2176 · MetaMask/metamask-mobile

rickycodes · 2021-01-28T01:06:04Z

Description

Adequately warn user when replacing wallet:

Screen.record.from.2021-01-27.20.01.49.mp4

Checklist

There is a related GitHub issue

Issue

Resolves #2115

ibrahimtaveras00

Issue 1:
~~The wording seems a little bit incomplete where we say "setup new"~~

Maybe "and setup a new wallet" or "and setup a new one"
cc: @cjeria @omnat

Issue 2:
~~Mispelling~~

~~Should be "permanently"~~

Issue 3:
~~On a smaller screen the modal is stretched out (example iPhone 5s)~~

Issue 4:
Delete confirmation doesn't pop up on iOS; seen here = http://recordit.co/A0w226up6u
Issue 5:
In the figma mock up, it states to re-use the 'Creating wallet' loading screen from onboarding flow, and then it says not to allow going back on the onboarding carousel from here. Also I didn't see the notification that my wallet was erased. All 3 are not implemented; seen here = http://recordit.co/DeEz3hGhIh

cjeria · 2021-02-02T22:16:27Z

Issue 1: Let's go with "Can’t log in? You can ERASE your current wallet and set up a new one".

Issue 3: Let's try reducing the left and right margins of the modal so all sides have equal spacing (the area around the modal showing the background). Experiment with 8px, 16px or 24px to see what looks best.

rickycodes · 2021-02-10T04:24:00Z

app/components/Views/ManualBackupStep3/index.js

 		this.steps = props.navigation.getParam('steps', undefined);
-		props.navigation.setParams({
-			headerLeft: <View />
-		});


this is just me undoing a previous silly thing i did.

app/components/Views/Onboarding/index.js

estebanmino

👌

estebanmino

lgtm

ibrahimtaveras00

QA Passed 👍🏽

* Remove best deals badge from WYRE transfers. (#2228) Co-authored-by: Shivam Chaturvedi <corsairshivam@gmail.com> * Handle `balanceError` case (#2148) * Handle `balanceError` case * Adjust error case * Update handling balanceError * Remove etherscan link * Add metamask-controllers from disk * Add translation strings * Remove etherscanUrl * Revert "Add metamask-controllers from disk" This reverts commit 75ac0c68b99e5bf2ff190c20cccad4df74a8806f. * Only use this style for error case * contract metadata images bump (#2233) * contractmetadata * snaps * remotesvg * Feature/warn when replacing (#2176) * mock login changes * mock warning modal * mock delete modal * mock delete warning and submitDelete * Add isTextDelete * Add autoFocus * clean up * "delete" * undo design changes * Add en translations * Update unit tests * fix * Make this async await and catch and log failure * Remove 12-word * Adjust lineHeight * fix typo * Add logic to show delete notification * Hide back button * Disable hardware back button press * Add notification * Add closeButtonDisabled functionality * Update styles * Hide back button better on Congratulations screen * Update translation * Add breakpoint for small devices * add missing "a" * fix warning modal * Clean up BaseNotification component * Remove added styles * Remove eslint-disable-next-line * Use InteractionManager * Remove empty onHide * update empty callback * Cleanup * Add flexDirection: 'row' * Move styles to WarningExistingUserModal * Dismiss keyboard * Add strings to locales * Simplify * Add loading screen for delete * Actually delete wallet * Fix modal tap area Co-authored-by: ricky <ricky@macbook.lan> * v1.0.11 (#2238) * version * bump * Update CHANGELOG.md * update * Update CHANGELOG * Remove disclosure PR * Fix circleci apk (#2240) * resouceclass * revert * Revert "revert" This reverts commit 60df2aa. * changelog * gaba * swaps-tx * MM_FOX_CODE * swaptxs * works * fix * TransactionController from controllers (#2243) * TransactionController from controllers * query * changelog * tests * 577 * 577 * details * transactionType * token * byaction * allworking * ceanup * locales * utils * check * edgecase * test * tests * approvals * filter * more Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Shivam Chaturvedi <corsairshivam@gmail.com> Co-authored-by: ricky <ricky.miller@gmail.com> Co-authored-by: ricky <ricky@macbook.lan>

* develop: (48 commits) Fix input state (#2265) bump android versionCode (#2260) bugfix/use bignumber for transfer deeplinks (#2257) Fix account list scroll (#2256) TransactionController from controllers (#2243) Fix circleci apk (#2240) v1.0.11 (#2238) Feature/warn when replacing (#2176) contract metadata images bump (#2233) Handle `balanceError` case (#2148) Remove best deals badge from WYRE transfers. (#2228) @metamask/controllers@6.0.1 (#2217) Fix cloudflare redirects (#2180) Merge pull request from GHSA-wmvx-96jh-gcr4 Update @metamask/contract-metadata (#2203) React Native update to 0.63 (#2078) Create dependabot.yml (#2204) Fix "Text strings must be rendered within a <Text> component" (#2193) Use navigate instead of push (#2191) Add fiat on ramp modal close button extra hit area (#2174) ...

* mock login changes * mock warning modal * mock delete modal * mock delete warning and submitDelete * Add isTextDelete * Add autoFocus * clean up * "delete" * undo design changes * Add en translations * Update unit tests * fix * Make this async await and catch and log failure * Remove 12-word * Adjust lineHeight * fix typo * Add logic to show delete notification * Hide back button * Disable hardware back button press * Add notification * Add closeButtonDisabled functionality * Update styles * Hide back button better on Congratulations screen * Update translation * Add breakpoint for small devices * add missing "a" * fix warning modal * Clean up BaseNotification component * Remove added styles * Remove eslint-disable-next-line * Use InteractionManager * Remove empty onHide * update empty callback * Cleanup * Add flexDirection: 'row' * Move styles to WarningExistingUserModal * Dismiss keyboard * Add strings to locales * Simplify * Add loading screen for delete * Actually delete wallet * Fix modal tap area Co-authored-by: ricky <ricky@macbook.lan>

rickycodes requested a review from a team as a code owner January 28, 2021 01:06

rickycodes force-pushed the feature/warn-when-replacing branch from 02d98c2 to 88b5e57 Compare January 28, 2021 01:06

rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 28, 2021

rickycodes force-pushed the feature/warn-when-replacing branch from c12990d to 78d7644 Compare January 28, 2021 23:02

ibrahimtaveras00 suggested changes Jan 29, 2021

View reviewed changes

ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 29, 2021

rickycodes force-pushed the feature/warn-when-replacing branch 2 times, most recently from 834e607 to c7b3750 Compare February 2, 2021 18:17

ibrahimtaveras00 added the next release label Feb 3, 2021

rickycodes force-pushed the feature/warn-when-replacing branch 4 times, most recently from dba806f to 70a5ed6 Compare February 4, 2021 19:37

rickycodes requested a review from ibrahimtaveras00 February 10, 2021 03:11

rickycodes added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Feb 10, 2021

rickycodes commented Feb 10, 2021

View reviewed changes

estebanmino reviewed Feb 10, 2021

View reviewed changes

app/components/Views/Onboarding/index.js Outdated Show resolved Hide resolved

omnat added next release and removed next release labels Feb 10, 2021

estebanmino approved these changes Feb 10, 2021

View reviewed changes

rickycodes force-pushed the feature/warn-when-replacing branch from d8b5317 to 9cb4f33 Compare February 10, 2021 23:06

rickycodes added 5 commits February 11, 2021 10:04

mock login changes

88b5040

mock warning modal

145c996

mock delete modal

3e0c74f

mock delete warning and submitDelete

872e07f

Add isTextDelete

dc0d64c

rickycodes and others added 17 commits February 11, 2021 10:04

Add breakpoint for small devices

2de534e

add missing "a"

f7ecce9

fix warning modal

3e450ef

Clean up BaseNotification component

096fc2a

Remove added styles

aa9fd1e

Remove eslint-disable-next-line

f341a50

Use InteractionManager

bd56293

Remove empty onHide

bd5206a

update empty callback

26ab86e

Cleanup

80b3477

Add flexDirection: 'row'

89a3f45

Move styles to WarningExistingUserModal

e0ca1af

Dismiss keyboard

6663d78

Add strings to locales

629baa8

Simplify

e70c70e

Add loading screen for delete

02e0a17

Actually delete wallet

61f671f

rickycodes force-pushed the feature/warn-when-replacing branch from 8bdc2ac to 61f671f Compare February 11, 2021 15:04

estebanmino approved these changes Feb 11, 2021

View reviewed changes

omnat removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 11, 2021

Fix modal tap area

193c0fe

ibrahimtaveras00 approved these changes Feb 11, 2021

View reviewed changes

ibrahimtaveras00 added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 11, 2021

rickycodes merged commit 9701249 into develop Feb 11, 2021

rickycodes deleted the feature/warn-when-replacing branch February 11, 2021 19:54

estebanmino mentioned this pull request Mar 30, 2021

Update terms and privacy links #2443

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/warn when replacing#2176

Feature/warn when replacing#2176
rickycodes merged 42 commits intodevelopfrom
feature/warn-when-replacing

rickycodes commented Jan 28, 2021 •

edited

Loading

Uh oh!

ibrahimtaveras00 left a comment •

edited by rickycodes

Loading

Uh oh!

cjeria commented Feb 2, 2021

Uh oh!

rickycodes Feb 10, 2021

Uh oh!

Uh oh!

estebanmino left a comment

Uh oh!

estebanmino left a comment

Uh oh!

ibrahimtaveras00 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

rickycodes commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ibrahimtaveras00 left a comment • edited by rickycodes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjeria commented Feb 2, 2021

Uh oh!

rickycodes Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

estebanmino left a comment

Choose a reason for hiding this comment

Uh oh!

estebanmino left a comment

Choose a reason for hiding this comment

Uh oh!

ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rickycodes commented Jan 28, 2021 •

edited

Loading

ibrahimtaveras00 left a comment •

edited by rickycodes

Loading